OpenUntis icon indicating copy to clipboard operation
OpenUntis copied to clipboard

Mark that room has changed

Open LLNNDD opened this issue 6 years ago • 5 comments

Currently if there was a change in the room, this app will display the changed room, but won't mark it specially, unlike the web version (and AFAIK the official version). This makes it easy to miss it if there was a change.

My feature request would be to implement it (by for example highlighting it with an different background).

LLNNDD avatar Feb 09 '19 15:02 LLNNDD

If you select "use colors from school" in the customization options, changes are highlighted. But as far as I know, the Untis API doesn't indicate such changes, so implementing this for all themes will be difficult

SapuSeven avatar Feb 09 '19 15:02 SapuSeven

If you select "use colors from school" in the customization options, changes are highlighted.

I tried this, but lessons with changed room aren't still marked in any way, at least in past lessons.

LLNNDD avatar Feb 11 '19 07:02 LLNNDD

Hmmm, that's weird. Maybe the API changed a bit...

SapuSeven avatar Feb 11 '19 10:02 SapuSeven

I've found this comment:

https://github.com/Perflyst/OpenUntis/blob/7b772cfdab3d3abeea425140ab896603b8df39f3/app/src/main/java/de/perflyst/untis/utils/timetable/TimetableItemData.java#L36

// id = current value | orgId = original value if for example the teacher has changed

I did dump then all requests and tried to look into the very big responses and I did found an instance where the id and orgId differed on a "ROOM" type on the matching day (but the ID-fests make it somewhat harder to map). However, the orgId attribute is never used or saved.

LLNNDD avatar Feb 11 '19 16:02 LLNNDD

Oh right, I totally forgot about that. In that case, it should be possible to implement this feature by comparing these two values for a lesson.

SapuSeven avatar Feb 11 '19 16:02 SapuSeven