PathOfBuilding icon indicating copy to clipboard operation
PathOfBuilding copied to clipboard

Extend default gem level functionality

Open Lothrik opened this issue 3 years ago • 4 comments

Fixes #4630.

This replaces the old gem level selection and "match gem level to character" level options with a dropdown selection that has four options:

  • Normal Maximum: All gems default to their highest valid non-corrupted gem level.
  • Corrupted Maximum: Normal gems default to their highest valid corrupted gem level. Awakened gems default to their highest valid non-corrupted gem level.
  • Awakened Maximum: All gems default to their highest valid corrupted gem level.
  • Match Character Level: All gems default to their highest valid non-corrupted gem level that your character meets the level requirement for. This hides gems with a minimum level requirement above your character level, preventing them from showing up in the dropdown list.

Before screenshot:

After screenshot:

Lothrik avatar Aug 09 '22 23:08 Lothrik

Merged #4761 to resolve conflicts. Fixes #4759 #2830

Lothrik avatar Aug 12 '22 16:08 Lothrik

There is also the issue that it won't hide gems on load either I wasn't sure how to resolve this one though.

QuickStick123 avatar Aug 12 '22 23:08 QuickStick123

The issue doesn't seem to be resolved and still uses normal gem level stuff when set to match character level and reload/load pob. Everything else seems to behave correctly.

QuickStick123 avatar Aug 13 '22 14:08 QuickStick123

@QuickStick123 That issue should be resolved. self:PopulateGemList() wasn't being called when sortCache was uninitialized, meaning the gem list was always incorrect on new/empty socket groups.

Lothrik avatar Aug 13 '22 17:08 Lothrik

@Wires77 33e22beed12df19dd1d044d8910f474281545691 should handle legacy build configuration settings properly.

Lothrik avatar Aug 15 '22 23:08 Lothrik

The only remaining issue I see with this is that it loses the functionality to say add level 15 gems if you want to make a early maps config or something similar easily.

QuickStick123 avatar Aug 19 '22 22:08 QuickStick123