PascalSenn

Results 177 comments of PascalSenn

This exception is a bit weird. If i remember correctly we deliberately added the null-checks back because of some EF Core behaviour. The visitor is able to "skip all null...

@jskeet The objection on `ReadOnlySpan` in the initial proposal was about the possibility of resizing the underlying array. https://github.com/protocolbuffers/protobuf/pull/6538#issuecomment-630114989 > Also note that exposing the data as read-only (ReadOnlySpan) addresses...

@jskeet I removed the exposed `ReadOnlyMemory` in the PR and added the note into the XML Doc string of `ReadOnlySpan`. I do not require `ReadOnlyMemory` for my use case as...

@protobuf-github-bot This PR is waiting for a review

Just realized that we may already have something like this

@TimHolzherr i cannot remember what i found in the codebase to do this tbh. But i usually use this approach: https://stackoverflow.com/questions/30333925/how-do-i-log-my-queries-in-mongodb-c-sharp-driver-2-0

@0xced Sorry that this took so long and thanks for the contribution

@JamesNK @jskeet I changed the implementation to include your suggestions. There is already a similar class `UnsafeByteOperations`, so I aligned the naming with it -> `UnsafeCollectionOperations`. The implementation of the...

@jskeet Most of this implementation closely aligned with `CollectionsMarshal.cs` from the runtime. The goal was to keep the implementation and behavior relatively consistent. I also believe a few things were...

@jskeet One last remark. The tests are ported from `CollectionsMarshalTests.cs` to ensure consistent behavior: https://github.com/dotnet/runtime/blob/main/src/libraries/System.Runtime.InteropServices/tests/System.Runtime.InteropServices.UnitTests/System/Runtime/InteropServices/CollectionsMarshalTests.cs