Iridium icon indicating copy to clipboard operation
Iridium copied to clipboard

AMO public listing version will no longer receive any more updates following the reviewers decisions

Open ParticleCore opened this issue 5 years ago • 18 comments

EDIT2: And after approving version 1.2.5 and 1.2.6, suddenly this is the notice I receive:

This version didn't pass review because of the following issue:

  1. Due to the refuse of providing the requested change we can not approve this version. You didn't comply with our request and the add-on installs a cookie without requesting user consent. Our policy states that the user must be provided an opportunity to refuse the storage of or access to cookies, and must be informed of the consequences of doing so (e.g., without a functional cookie, the add-on may not work). The rejected versions don't adhere to the add-on's policy.

Versions affected are 1.0.0 to 1.2.6 (all of which contained the cookie permission) were removed with no prior notice, i.e. no warning was given telling me that if their demand was not satisfied all the versions would be removed, but I guess at this point it's useless to expect better from them, at least I was always straight forward since day one and never hid my intentions.

Additionally I've received an email threatening the following (shortened to the most important parts):

This message is to let you know that recently you have violated Mozilla's Community Participation Guidelines ("CPG"). The actions that are alleged to have violated the CPG are:

  • Disrespectful behavior in conversation with the reviewer

Your next step is to indicate you have received this email and agree to cease actions like this in the future.

Result: The public version of the add-on will no longer receive any more updates due to the reviewer's decisions.

The unlisted version will be the only one receiving any updates from now on.


EDIT: Looks like version 1.2.5 was finally approved, but as a result the extension has been removed from the recommended add-ons based on the claim that I am "inclined to halt development of Iridium, or the listed version, at least", which is laughable given that 1.2.5 is literally an update to make the extension continue to work as a result of a Firefox bug.

Either way I don't care, my main and only concern was to make sure users have a working version, if it is recommended or not is not my priority.


Version 1.2.5 was released and submitted for the AMO public listing. This fix is actually a workaround for a bug that Firefox has yet to fix (read more here). In the update nothing else was added or modified, the workaround was the only thing implemented A reviewer decided to ask for the add-on to implement a prompt for disclosing the use of the cookie permission, quoting:

  1. The user must be provided an opportunity to refuse the storage of or access to cookies, and must be informed of the consequences of doing so (e.g., without a functional cookie, the add-on may not work)

Not only the user has to be told the reason for the use of the permission (which is already disclaimed in the AMO add-on description), but the add-on would also need to allow the user NOT authorize the use of that permission, EXPLAIN what will happen if the user does so and let the developer deal with whatever consequence that causes to the add-on.

Basically we - developers - now have to do what the browser itself should be doing and implement permission control for the user to authorize or reject the use of each permission.

I have very limited time at the moment to dedicate to the add-on, I've been always doing my best to at least keep it working when something breaks and I have endured countless retarded (there is no other way of saying this) demands by the AMO reviewers. I've had one reviewer once demanding for me to undo all the changes that a content script does on any page it runs on when the addon is uninstalled. For those of you that understand what this means, you also understand why I use the word "retarded".

I'm tired, I'm busy and I have no time to waste any more on this kind of circus. If the add-on on the AMO store does not receive any more updates that means they insist on being unreasonable and I will no longer tolerate that.

The unlisted version is exactly the same, is updated and also receives updates faster. If you wish to continue receiving updates you can find the most recent version here: https://github.com/ParticleCore/Iridium/wiki/Download

I am sad that it comes down to this since I was personally asked to return to the AMO store and I thought I'd give it one last shot, but I have a life and my health to prioritize.

ParticleCore avatar Mar 20 '20 20:03 ParticleCore

This is one change that i find to be very stupid that firefox implements. Some devs aren't able to change their addon's every time firefox or even google chrome changes things.

ghost avatar Mar 23 '20 05:03 ghost

I'd rather time be dedicated to development instead of fighting the store so makes sense to me.

karma12gaming avatar Mar 23 '20 10:03 karma12gaming

Permission management is maybe something that should be implemented at the browser level itself, much like how Google has done it with later Android versions. No sense in reimplementing the wheel for every addon created if this is something they're going to require of everyone.

That being said, I also understand that not every user will be comfortable with an addon having access to their cookies and if the option can't be turned off will just choose not to use the addon. So it wouldn't be a bad idea to have a toggle switch for that feature, if it's not something essential to the addon functionality (generally speaking, many people might not need those couple of features that granting a certain permission enables and would be just fine turning the permission off)

But if the addon is managing its own permissions, how can you trust the developer that they don't collect cookies in the background (hypothetically speaking) even when the feature is turned off? Permissions have to be implemented at the browser level for them to actually be meaningful.

So while I think it's a nice idea their suggestion of implementing it at the addon level makes no sense to me.

Jdbye avatar Mar 27 '20 00:03 Jdbye

@Jdbye I agree with everything you said, it is exactly like that. I hope they implement it in the browser and when that day comes I will gladly update the add-on to comply with the new changes and handle each permission user control. Until then it will stay as it is.

ParticleCore avatar Mar 27 '20 00:03 ParticleCore

Main topic has been updated with new information.

ParticleCore avatar Mar 31 '20 18:03 ParticleCore

The topic has been updated with the final information.

ParticleCore avatar Apr 01 '20 20:04 ParticleCore

@ParticleCore You should create a simple page (maybe on GitHub Pages) with a link to .xpi file.
Firefox will ask to install add-on. So, it may simplify installation steps.

.xpi link on GitHub won't make Firefox ask to install because of GitHub response raw link with application/octet-stream content type instead of application/x-xpinstall.

ภาพ

ภาพ

gluons avatar Apr 02 '20 12:04 gluons

@gluons Thanks for the suggestion. That is correct, GitHub serves the link with an incorrect content type (or correct, depending on the point of view), which is why I've included the instructions.

I don't know if serving the file through the GH pages will make the content type work correctly, but worth a short for sure so I will check it and if it works I will update the wiki with the new link.

ParticleCore avatar Apr 02 '20 15:04 ParticleCore

I've created experimental download page (https://gluons.gitlab.io/iridium-download-page/).
Not sure whether it'll work or not.

gluons avatar Apr 06 '20 12:04 gluons

@gluons I just tried it. It works perfectly. Also, cool trick of using jsDelivr. Good job! :)

amjd avatar Apr 17 '20 19:04 amjd

Will there ever be a version for Chrome?

NovaViper avatar Apr 28 '20 23:04 NovaViper

Will there ever be a version for Chrome?

When Chrome implements the API, until then it's a no since the API just doesn't exist in Chrome.

ParticleCore avatar Apr 29 '20 00:04 ParticleCore

@gluons Is it just my mistaken memory or is the Iridium version on the download page missing some features? Wasn't iridium able to reverse the YT playlist order? In any case thanks for your efforts! I could not manually install the addon because it was giving a corrupted error

octapusxft avatar May 05 '20 06:05 octapusxft

@octapusxft

In any case thanks for your efforts! I could not manually install the addon because it was giving a corrupted error

Have you tried installing via manual method? Does it work?
My site is experimental. I'm not sure if it'll work perfectly.

If you see any issue, try fillng issue in my repo.


Is it just my mistaken memory or is the Iridium version on the download page missing some features? Wasn't iridium able to reverse the YT playlist order?

If you can install Iridium correctly and still don't see your expected features, maybe it's because of new version (Starting from scratch). Many features are coming I guess.

Or you can ask @ParticleCore about features (maybe in the other new issue?) after you can install Iridium correctly.

gluons avatar May 05 '20 06:05 gluons

@gluons The manual install gives me an error that the files are corrupted and wont proceed. I do not know why. Anyway I will try not bothering ParticleCore for now I will try again in the future and if I have issues I will make a bug report.

octapusxft avatar May 05 '20 12:05 octapusxft

Remember to uninstall previous versions before installing a new one if you intend to switch from the AMO store hosted version to the GitHub hosted version.

ParticleCore avatar May 05 '20 13:05 ParticleCore

Anyone care to explain what the f* is 'AMO'?

electrofloat avatar Aug 30 '20 16:08 electrofloat

AMO stands for addons.mozilla.org.

gluons avatar Aug 30 '20 17:08 gluons