hookrouter icon indicating copy to clipboard operation
hookrouter copied to clipboard

Is library still maintained ? Are PRs accepted ?

Open olup opened this issue 5 years ago • 9 comments
trafficstars

Pretty much just the title ;-)

olup avatar Mar 10 '20 08:03 olup

Yeah, I mentioned in the past that I have extremely low free time to work on it. But I am working on version 2.0 of the router.

PRs are meaningless right now, since I do a complete rewrite of the codebase. Since we are now in lockdown because of Covid19 here in germany, I hopefully get some more time to work on it, if my daughters sleep well at night. Yesterday I made good progress in writing the router core code and will try to add react and preact connectors tonight.

Stay tuned - its not dead :)

Paratron avatar Mar 16 '20 11:03 Paratron

Good to hear, this lib has great potential. Are you writing it up again in Typescript ? Would be good to have types natively embedded.

On Mon, Mar 16, 2020 at 12:14 PM Christian Engel [email protected] wrote:

Yeah, I mentioned in the past that I have extremely low free time to work on it. But I am working on version 2.0 of the router.

PRs are meaningless right now, since I do a complete rewrite of the codebase. Since we are now in lockdown because of Covid19 here in germany, I hopefully get some more time to work on it, if my daughters sleep well at night. Yesterday I made good progress in writing the router core code and will try to add react and preact connectors tonight.

Stay tuned - its not dead :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Paratron/hookrouter/issues/112#issuecomment-599479322, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADJFT5D4ZOYO3GNBCGQZ2WLRHYC2DANCNFSM4LEZIIOA .

olup avatar Mar 16 '20 17:03 olup

Sorry this came wrong from my inbox. Was wondering : are you rewriting this in typescript by any chance? We would greatly benefit from proper types.

olup avatar Mar 17 '20 18:03 olup

I am rewriting this, since it was initially only a proof of concept and suffered from a couple of architectual problems.

I will not write any library ever in typescript. I dislike typescript for a number of reasons and will never use it if I don't absolutely have to.

Paratron avatar Mar 17 '20 19:03 Paratron

I am rewriting this, since it was initially only a proof of concept and suffered from a couple of architectual problems.

Proof of concept ? I don't think this was mentioned anywhere..... (Is shocked and passes out)

StallionV avatar Mar 26 '20 18:03 StallionV

I think I did mention it in my initial article about it. I wrote down the idea of it in the matter of two hours during a weekend and it was suprisingly stable but in the long run turned out to have some issues that made it hard to implement serverside rendering.

Paratron avatar Mar 26 '20 19:03 Paratron

I was impressed at the size and simplicity of the hookrouter API when I first tried it. When development stopped and bugs turned into blockers I decided to build my hook-based router.

For those of you like @olup who are looking for a path forward raviger just released its v2. It has been under active development since its start two years ago, is in use in several production systems, and most bugs are closed within a day or two. The API is not drop-in compatible, but its close enough that it should be easy for most people to switch.

kyeotic avatar Nov 17 '20 21:11 kyeotic

Well, I believe react-router v6 now supports very similar DX, so I think it remains the better choice.

olup avatar Nov 17 '20 22:11 olup

@olup That probably true if DX or familiarity are your top concerns. React-router very large compared to raviger or hookrouter, more than 5x the size gzipped. If bundle size is a high priority you might consider a slimmer option :)

kyeotic avatar Nov 18 '20 05:11 kyeotic