Carlos Parada

Results 396 comments of Carlos Parada

> Just as an update, I fixed a bug in StrideArraysCore so that it now gets the correct answer, but `@threads` is several times faster than `@batch` for me. I...

It would also make some constructors seem more sensible -- it feels weird that `VarInfo(model)` creates a new sample, but `Sample(model)` is quite intuitive!

> I guess the name is motivated by the fact that it contains much more than just the samples. ATM, `SimpleVarInfo` contains only the samples and the log-probability (which I...

Makes sense; maybe just change `SimpleVarInfo` then?

> > That would also be good; no reason not to do both! > > The main reason to not do both is that it creates confusion if there are...

@torfjelde any comment on a different name?

(Worth noting: I got the answers to my questions on the Slack already, so there's not a need to answer in this thread. This is here because @yebai asked me...

Ironic, I came in here asking this question and I’m coming out answering it

(Removing the RNG leads it to run as expected)

> Speecifying both a sampling context and an RNG is redundant, hence IMO this should not be supported. But as mentioned in the comment linked above, we should clean the...