Waterfall icon indicating copy to clipboard operation
Waterfall copied to clipboard

Feature request: Plugin identification in stack traces

Open SlimeDog opened this issue 4 years ago • 7 comments

Please consider incorporating the functionality of https://github.com/PaperMC/Paper/pull/6142 into Waterfall?

SlimeDog avatar Aug 02 '21 14:08 SlimeDog

Would turn into a quite hacky implementation as Bungeecord/Waterfall are still java 8.

Janmm14 avatar Aug 02 '21 15:08 Janmm14

Is there a reason they are still Java 8? For heaven's sake, we're on Java 16 now -- enforced for MC/Spigot/Paper.

SlimeDog avatar Aug 02 '21 15:08 SlimeDog

I was too busy/ill to deal with the timeline to bump waterfall, bumping the min version is on the todo list it's just getting the timeline in place, warnings out, ensuring that shit won't go sideways as it did last I tried messing with the java version \o/

electronicboy avatar Aug 02 '21 15:08 electronicboy

You should also add something like https://github.com/Janmm14/BungeeCord/commit/b2a4bab5e9757e5cdf6bde5026198a1dd7cc21af then. Stack trace might display the version of the plugin then as well (not tested).

Janmm14 avatar Aug 02 '21 16:08 Janmm14

Yea, that's what I was actually looking into doing with paper itself a while ago, afaik, so long as you get the manifest info in there it should be able to pick it up

electronicboy avatar Aug 02 '21 16:08 electronicboy