Velocity
Velocity copied to clipboard
PaperMC
Set proxy to build with Java 11 compatibility
Not sure if this is the correct way to do it, but I use Java 18 on my system and building Velocity results in the proxy jar not being compatible with Java 17.
I don't think this change is so necessary, it would only affect custom builds, and in that case, everyone can modify Velocity as required
I mean that if you clone the project directly or through a fork it will affect when compiling on your own, but for the official Velocity distribution it will not have any effect
to my understanding, one should set it through the toolchain, that way it can do other stuff like ensuring that pulled in stuff is compatible with 11 and that the final output supports 11
to my understanding, one should set it through the toolchain, that way it can do other stuff like ensuring that pulled in stuff is compatible with 11 and that the final output supports 11
So do you mean that I should set my system's Java version instead when building? It's kind of annoying to do that, I feel like it makes the most sense for it to build properly automatically, instead of needing to be set properly in CI, or on your own system or whatever.
No, I mean using he gradle toolchain system, which basically properly sets the JVM release, etc, properly
I also see that in api/build.gradle and native/build.gradle, it uses sourceCompatibility and targetCompatibility to set the Java version. Should this be changed to Gradle toolchain as well?
I went ahead and made this change as part of the conversion of Velocity to use Gradle's Kotlin DSL
