Velocity
Velocity copied to clipboard
Implement MiniMessage Velocity translations
resolves https://github.com/PaperMC/Velocity/issues/720
Won't this break existing translations from the lang folder?
Won't this break existing translations from the
langfolder?
Yes, I was also thinking of integrating a migration once https://github.com/PaperMC/Velocity/pull/1111 is merged
Won't this break existing translations from the
langfolder?Yes, I was also thinking of integrating a migration once #1111 is merged
Implemented a migration to the new format, this pull request is ready for another review
This has my approval, and the prerequisite PR has been pulled, just need to figure out what to do regarding crowdin
Only issue I have when testing is that tooltips appear not properly to parse from the messages.properties file properly
Managed to fix it with these changes. Thought this'd help speed up the state of this PR (ignore the messages.properties changes, except for the Plugins: one:
or https://github.com/GemstoneGG/Velocity-CTD/compare/libdeflate%40%7B1day%7D...libdeflate
I just implemented this into my Paper plugin, and noticed that single quotes behave differently using the code in 'VelocityTranslationRegistry' as opposed to using 'TranslationRegistry.create()' directly.
Normally, MessageFormat converts double single quotes '' into '. Now, double single quotes are left unchanged, and a single ' gets removed. Not too big of a deal, but I still wanted to share. Can someone verify this? Notable: MessageFormat.toPattern().
Also: ' and '' are used interchangeably in the property files. Nice addition! 👍