Paper icon indicating copy to clipboard operation
Paper copied to clipboard

OfflinePlayer advancements

Open Machine-Maker opened this issue 4 years ago • 13 comments

Closes #5486

Machine-Maker avatar Apr 22 '21 08:04 Machine-Maker

making this mutable in any capacity does not look safe?

electronicboy avatar Apr 30 '21 14:04 electronicboy

Granting criteria is disabled. The AdvancementProgress object that is give to the plugin has that overridden to throw an exception. Removing criteria however, does seem safe. I did do a bit of testing.

Machine-Maker avatar Apr 30 '21 14:04 Machine-Maker

I have intents down the line to rewrite how data is handled in the server, wanna make player file I/O non-blocking

any modifications to this data must all be done in a single tick, cannot get the data in one tick and then modify the next safely, etc; this sorta makes me weary, and i'd much rather this class be AutoClosable vs explicitly calling data.save() each time, it allows us to accommodate the async flow better in the future and means that you're not writing back to the disk each modification, but, there are defo caveats on how this API works

electronicboy avatar Apr 30 '21 15:04 electronicboy

Ok, well we can make it immutable for now at least.

Machine-Maker avatar Apr 30 '21 15:04 Machine-Maker

Rebased for 1.17.1

Machine-Maker avatar Jul 09 '21 06:07 Machine-Maker

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 08 '21 04:09 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 22 '21 02:11 stale[bot]

Rebased for 1.18.1

Machine-Maker avatar Dec 25 '21 06:12 Machine-Maker

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Feb 23 '22 07:02 stale[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 24 '22 22:04 stale[bot]

Rebased for 1.18.2

Machine-Maker avatar Apr 24 '22 22:04 Machine-Maker

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 24 '22 01:06 stale[bot]

Rebased for 1.19

Machine-Maker avatar Jun 25 '22 21:06 Machine-Maker