Paper
Paper copied to clipboard
OfflinePlayer advancements
Closes #5486
making this mutable in any capacity does not look safe?
Granting criteria is disabled. The AdvancementProgress object that is give to the plugin has that overridden to throw an exception. Removing criteria however, does seem safe. I did do a bit of testing.
I have intents down the line to rewrite how data is handled in the server, wanna make player file I/O non-blocking
any modifications to this data must all be done in a single tick, cannot get the data in one tick and then modify the next safely, etc; this sorta makes me weary, and i'd much rather this class be AutoClosable vs explicitly calling data.save() each time, it allows us to accommodate the async flow better in the future and means that you're not writing back to the disk each modification, but, there are defo caveats on how this API works
Ok, well we can make it immutable for now at least.
Rebased for 1.17.1
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rebased for 1.18.1
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rebased for 1.18.2
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rebased for 1.19