Paper
Paper copied to clipboard
Use internals for getting block/entity counts
For a long time I've been meaning to move some of this logic internally as this would allow us to avoid hitting systems like block state snapshots which can create issues as many of the spigot implementations of this stuff are increasingly broken, leading to unexpected crashes during ticking, even if the API cannot properly interact with these such states/items, it's generally more preferable to not crash the server in the course, and just let those interactions fail more gracefully.
forced pushed to better deal with the wrong base so I can reduce the diff noise induced
I think we can probably just close this right? All this is timings-related diff and we're just gonna remove timings.
With spark merged, timings disabled by default now and deprecated for future removal in #11128, I'll close this PR, sorry cat </3