Paper icon indicating copy to clipboard operation
Paper copied to clipboard

Add velocity forwarding secret file support

Open oliverjanka opened this issue 1 year ago • 6 comments

Currently the secret can only be specified as string in the config. This makes it almost impossible to run the server within a containerized environment like Kubernetes. Also I don't want secret data to be specified along with 'general' data.

This PR aims to add the functionality to load the secret from an external file (like it is already the default in velocity)

oliverjanka avatar Jan 04 '24 09:01 oliverjanka

FYI: I only changed the files GlobalConfiguration, VelocityProxy and PaperConfigurations I don't know why rebuildPatches also changed the other patches.

oliverjanka avatar Jan 04 '24 09:01 oliverjanka

Being frank, this has kinda been on the todo list for a while, but if we wanna do this, we would want to maintain consistency with velocities current expected behavior, i.e. the secret if already set should probably be migrated to the file, and we should follow the file naming of velocity so that people can just copy the file over and save confusion

I would maybe await others comments on this, however

electronicboy avatar Jan 04 '24 09:01 electronicboy

@electronicboy I added functionality to migrate in-config secrets to file automatically. I hope this fits what you meant.

oliverjanka avatar Jan 04 '24 13:01 oliverjanka

I really need this feature to run a minecraft server securely on k8s. So i'm looking forward to see the merged pullrequest. @electronicboy

jorishaenseler15 avatar Jan 12 '24 15:01 jorishaenseler15

Bump

Nevah5 avatar Jan 17 '24 13:01 Nevah5

@Machine-Maker what's the status of this issue?

oliverjanka avatar Aug 25 '24 15:08 oliverjanka