erc404 icon indicating copy to clipboard operation
erc404 copied to clipboard

centralize validValueOrId check

Open mathdroid opened this issue 1 year ago • 4 comments
trafficstars

          just an idea, not needed for this version: this logic could be a function since we reuse it everywhere, it's critical, and when we want to support burning it will need to be changed in many places.

Originally posted by @caldereth in https://github.com/Pandora-Labs-Org/erc404/pull/17#discussion_r1487190473

mathdroid avatar Feb 13 '24 09:02 mathdroid

@mathdroid is this being worked upon ?

aruns05 avatar Feb 24 '24 08:02 aruns05

it should already be in the current impl. closing after confirmation @0xacme @caldereth

mathdroid avatar Feb 24 '24 08:02 mathdroid

I think that the _isValidTokenId implements this and is present in the main branch.

gaavar avatar Feb 24 '24 08:02 gaavar

Is there any other good first issue,interested in contributing

aruns05 avatar Feb 24 '24 12:02 aruns05