talawa-api icon indicating copy to clipboard operation
talawa-api copied to clipboard

Resolvers: Tests for createMessageChat.ts

Open SiddheshKukade opened this issue 3 years ago • 5 comments

The Talawa-API code base needs to be 100% reliable. This means we need to have 100% test code coverage.

Tests need to be written for file /lib/resolvers/Mutation/createMessageChat.ts

  • We will need the API to be refactored for all methods, classes and/or functions found in this file for testing to be correctly executed.
  • When complete, all methods, classes and/or functions in the refactored file will need to be tested. These tests must be placed in a single file with the name tests/resolvers/Mutation/createMessageChat.ts. You may need to create the appropriate directory structure to do this.

IMPORTANT:

Please refer to the parent issue on how to implement these tests correctly:

  • https://github.com/PalisadoesFoundation/talawa-api/issues/490

PR Acceptance Criteria

  • When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
  • The current code coverage for the file can be found here. If the file isn't found in this directory, or there is a 404 error, then tests have not been created.
  • The PR will show a report for the code coverage for the file you have added. You can use that as a guide.

SiddheshKukade avatar Dec 05 '22 05:12 SiddheshKukade

@SiddheshKukade did you mean the path src/lib/resolvers/Mutation/createMessageChat.ts? If yes, the current test coverage of this file is 96%. I want to work on this file, can you please assign me?

beingnoble03 avatar Dec 09 '22 07:12 beingnoble03

@palisadoes sir, please take a look.

SiddheshKukade avatar Dec 09 '22 07:12 SiddheshKukade

@beingnoble03 You are already working on two other issues. Please complete those first.

palisadoes avatar Dec 09 '22 17:12 palisadoes

@palisadoes I am not working on any issue right now. All the issues, that I was assigned, are closed as the files that were linked by these issues had a code coverage of 100% already. So, can I work on this?

beingnoble03 avatar Dec 09 '22 18:12 beingnoble03

Travelling this week. Will open a PR next week. Sorry for the delay.

beingnoble03 avatar Dec 10 '22 13:12 beingnoble03