node-maxmind-db icon indicating copy to clipboard operation
node-maxmind-db copied to clipboard

The /test alone bloats up this module's size by over 10000%

Open CamiloMM opened this issue 10 years ago • 6 comments
trafficstars

Having such a huge-ass .mmdb file in the /test dir bloats the package from < 300kb to > 29mb. That's over 10000% increase in size for something that virtually nobody will ever use.

Please think of the children and download this file on-demand for tests (MaxMind doesn't change the URL so it would be easy).

                  he can't bear it

Do you see that polar bear? He's sad because his rainforest is melting, his ozone layer is being fracked, he's almost ran out of Coca-Cola and his hard-drive is full of bloated NPM modules, and it's all your fault.

How can he save that naughty asian panda porn now? :( Please fix. For the pandas. For the future.

CamiloMM avatar May 31 '15 04:05 CamiloMM

Maxmind also provides small test databases.

oschwald avatar May 31 '15 13:05 oschwald

That's neat, but they're still several megabytes in size (GeoIP2-City-Test.mmdb is 19mb).

CamiloMM avatar May 31 '15 21:05 CamiloMM

I think you are misreading the file size. That file is 19 kb in size.

oschwald avatar May 31 '15 22:05 oschwald

You're right, I read "19.093 kb" as "19,093 kb". That size is perfectly fine to publish on NPM!

CamiloMM avatar Jun 03 '15 00:06 CamiloMM

Please consider using .npmignore to exclude files when publishing to npm

behcet avatar Oct 15 '15 18:10 behcet

https://github.com/runk/node-maxmind

knoxcard avatar Dec 28 '18 05:12 knoxcard