Preston Thorpe
Preston Thorpe
I see the git history is diverged enough where it might have to be rebased off main to one commit :/
Ok so https://docs.rs/nu-ansi-term/latest/nu_ansi_term/struct.AnsiGenericString.html that's what we are working with. As you an see it's just the `&str` and a `style`. So those methods can be easily replaced. You can access...
Have we considered just creating a struct and `impl serde::Serialize` (nu_ansi_term supports this for the ansi codes) and doing `to_string_pretty()`?
I'm all for it. Yeah this is really more about clap and anything that would come along with it that would have breaking changes than it would be actually 1.0...
Thanks for the fix! Could you edit your commit msg to conform to conventional commits? Then we are all set to merge :+1:
This looks good to me :+1: Thanks for the PR! ping @cafkafk for CO review
There are some very insightful ideas here, particularly around the style/theme-ing. I've been working on the config/theme file, which required a pretty huge refactor in this area, so I think...
Version 16.2 we still would have been using `num_cpu`'s as the rayon update came in 18.0 or maybe 17.9 so it's quite possible. Could you try this on the main...
commit msg should probably be `feat(icons)` instead of `feat(docker)`. looking at this now
> poke @PThorpe92 my fault buddy what was the issue you were having again?