PSeitz comments

Results 319 comments of


                                            PSeitz

feat: cardinality aggregation

Looks good so far, I left some comments. I don't think `hyperloglog` is really big on its own, but all aggregations together may cost quite a bit if you don't...

feat: cardinality aggregation

Thanks @raphaelcoeffic !

change debug_assert to assert in term length

I don't see an impact on indexing performance

Be able to use range query with values containing space

Can you share your config?

Panic occured while committing writer with sort by text field.

sort by is only supported on numerical fields. Why do you want to sort by text field?

Panic occured while committing writer with sort by text field.

> For keeping the order, I would like to sort by the id field with text type. Why do you want to keep order in the tantivy index? > I...

provide size of uncompressed data

There's the `content_size` flag in the frame format header, but it's existence is optional. Also there may be multiple frames. So it would be the sum of the `content_size`. >...

provide size of uncompressed data

`current_frame_info` in `FrameDecoder` is private and depends on the current frame

provide size of uncompressed data

It's not accessible currently. It's existence is optional, so not sure what it can be used for externally

decompress a `.lz4` file?

Can you retry using `std::io::copy` like in the examples instead of a single read call? https://docs.rs/lz4_flex/latest/lz4_flex/#example-decompress-data-on-stdin-with-frame-format