prql icon indicating copy to clipboard operation
prql copied to clipboard

Published 20 hours ago • verified publisher icon PRQL

Allow examples to be extracted on Windows

Open max-sixty opened this issue 3 years ago • 2 comments
trafficstars

I just fixed the GHA spec so it actually ran on Windows.

Unfortunately this is now failing! I'm going to comment out the test, which runs on main, and open a PR to add it back.

Is anyone familiar with what could be going on? Or have easy access to a Windows machine to debug? I haven't used Windows in a long time...

max-sixty avatar Apr 14 '22 17:04 max-sixty

Here's an example failure: https://github.com/prql/prql/runs/6030035804?check_suite_focus=true

max-sixty avatar Apr 14 '22 21:04 max-sixty

This is a diagnosis in https://github.com/prql/prql/pull/358. It's driven by https://github.com/raphlinus/pulldown-cmark/issues/507. We're skipping this on Windows for the moment.

I won't be the best person to fix, since I don't have a windows machine, but we'd welcome a PR. We'd also welcome an upstream fix.

max-sixty avatar Apr 15 '22 02:04 max-sixty