Update Xlsx.php

Open riverdale74 opened this issue 2 years ago • 1 comments

Handle "default" cases by creating an empty string table entry.

I added these lines after observing that $sharedStrings was being indexed incorrectly with a test xlsx file. Adding these lines fixes that error.

This is:

Checklist:

[ ] Changes are covered by unit tests
- [ ] Changes are covered by existing unit tests
- [ ] New unit tests have been added
[X] Code style is respected
[X] Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
[ ] CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
[ ] Documentation is updated as necessary

Provide an explanation of why this change is needed, with links to any Issues (if appropriate). If this is a bugfix or a new feature, and there are no existing Issues, then please also create an issue that will make it easier to track progress with this PR.

Handle "default" cases by creating an empty string table entry.

I added these lines after observing that $sharedStrings was being indexed incorrectly with a test xlsx file. Adding these lines fixes that error.

Apr 10 '23 18:04 riverdale74

Can you provide a unit test that will demonstrate the issue, and prove that this fix works?

Apr 10 '23 20:04 oleibman

No update in over a year. Closing.

May 16 '24 04:05 oleibman