PHPWord icon indicating copy to clipboard operation
PHPWord copied to clipboard

Published 20 hours ago • verified publisher icon PHPOffice

[TYPO] Fix hardcoded macro chars in TemplateProcessor method

Open glafarge opened this issue 1 year ago • 1 comments

Description

Replace hardcoded macro chars by the customized ones in deleteRow() method of TemplateProcessor class

Checklist:

  • [ ] My CI is :green_circle:
  • [ ] I have covered by unit tests my new code (check build/coverage for coverage report)
  • [ ] I have updated the documentation to describe the changes
  • [ ] I have updated the changelog

glafarge avatar Jun 04 '24 16:06 glafarge

Coverage Status

coverage: 97.208%. remained the same when pulling eb4dd2ee2a5f7e455c702418d9c978944dd3aeed on glafarge:patch-1 into 2daa50c6f34c9cb6c532f72350e4bd8d466d6c71 on PHPOffice:master.

coveralls avatar Jun 04 '24 17:06 coveralls

@glafarge Could you update the changelog, please ?

Progi1984 avatar Aug 07 '24 14:08 Progi1984

@Progi1984 Done :wink:

glafarge avatar Aug 07 '24 16:08 glafarge

Thanks @glafarge ☺️

Progi1984 avatar Aug 07 '24 16:08 Progi1984

Coverage Status

coverage: 97.211% (+0.003%) from 97.208% when pulling 827a570f48862f1d894363a66d63e78ea11dfe77 on glafarge:patch-1 into 2daa50c6f34c9cb6c532f72350e4bd8d466d6c71 on PHPOffice:master.

coveralls avatar Aug 07 '24 16:08 coveralls