hierarchy views

[PhilipDeegan]

github wouldn't let me reopen the previous PR

Summary by CodeRabbit

• New Features

  • Integrated search functionality for improved content accessibility.
  • Added a search bar to the main interface.

• Style

  • Enhanced visual styles of the search bar for improved user experience and interface consistency.

• Documentation

  • Updated user documentation to include guidance on utilizing the new search feature.

[coderabbitai[bot]]

[!IMPORTANT]

Auto Review Skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

35 files out of 92 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

[!WARNING]

.coderabbit.yaml is using a deprecated configuration schema

The configuration schema (version 1) is deprecated and will be removed on 19th May 2024. Please migrate to the latest schema version.

New Configuration YAML

early_access: false
language: en
tone_instructions: ''
knowledge_base:
  learnings:
    scope: auto
  issues:
    scope: auto
  jira:
    project_keys: []
  linear:
    team_keys: []
chat:
  auto_reply: true
reviews:
  profile: chill
  request_changes_workflow: false
  high_level_summary: true
  high_level_summary_placeholder: '@coderabbitai summary'
  poem: false
  review_status: true
  collapse_walkthrough: true
  path_filters: []
  path_instructions:
    - path: '**.hpp'
      instructions: >-
        Review the C++ code, point out issues relative to principles of clean
        code, expressiveness, and performance.
  tools:
    shellcheck:
      enabled: true
    ruff:
      enabled: true
    markdownlint:
      enabled: true
    github-checks:
      enabled: true
      timeout_ms: 90000
    languagetool:
      enabled: true
      disabled_categories:
        - TYPOS
        - TYPOGRAPHY
        - CASING
      enabled_only: false
      level: default
  auto_review:
    enabled: true
    ignore_title_keywords:
      - WIP
    labels: []
    drafts: true
    base_branches:
      - master

Configuration Instructions

• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

The changes indicate a significant refactoring of a codebase, likely for a scientific simulation software, with a focus on improving the template parameterization and resource management. The refactoring introduces a new Grid class, replacing the Field class in many instances, and modifies the handling of physical models, messengers, and resources management to accommodate this change. Additionally, there is an emphasis on type safety and modern C++ practices, such as using auto* and constexpr functions, and enhancing the numerical models and solvers with new functionalities and optimizations.

Changes

File Pattern	Change Summary
res/cmake/*.cmake	Updated CMake configuration, fixing a typo and reflecting project structure reorganization.
src/amr/.../field_data.hpp, src/core/data/field/field.hpp	Updated field data handling, including assertions and pointer usage. Field class now inherits from NdArrayView.
src/amr/.../*.hpp	General overhaul of template parameters to use GridT or Grid_t and improved resource management. Introduced new solver classes and strategies.
src/core/data/grid/*.hpp, src/core/data/ions/*.hpp, src/core/data/ndarray/*.hpp	Introduced Grid class and updated related classes with new member variables and methods. Enhanced NdArrayView functionalities.
src/core/data/electrons/*.hpp, src/core/data/tensorfield/*.hpp, src/core/data/vecfield/*.hpp	Adjustments to electron and field classes, including new methods and reorganization.
src/core/.../*.hpp, src/core/utilities/*.hpp	Various enhancements and code cleanups, including new template structs and utilities.
src/diagnostic/.../fluid.hpp, src/phare_core.hpp, src/phare_solver.hpp, src/simulator/.../phare_types.hpp	Updated diagnostic types and core type declarations to align with new changes.
tests/amr/.../*, tests/core/data/*, tests/core/numerics/*	Reflected changes from Field to Grid in tests, updated type aliases, and included new headers.
tests/initializer/*.hpp	Simplified initialization functions by removing unnecessary parameters.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[nicolasaunai]

no Field* anymore, setBuffer only in Field (not talking about particles).

[nicolasaunai]

are dicts taken as references in several objects (IonPopulations, etc.) that we now copy without remorse keeping python alive?

[PhilipDeegan]

are dicts taken as references in several objects (IonPopulations, etc.) that we now copy without remorse keeping python alive?

created a new issue for this https://github.com/PHAREHUB/PHARE/issues/803 not really relevant to this PR