PGM icon indicating copy to clipboard operation
PGM copied to clipboard

Sync map protos with plugin versions

Open Indicardo opened this issue 5 years ago • 8 comments
trafficstars

With the release of 1.8 PGM, some modules have been added and others have been scrapped. The old proto versioning is obsolete and we need a new way to specify what PGM version an XML file was created for.

Indicardo avatar May 07 '20 22:05 Indicardo

You would still need to support protos for older XML, why not just jump to 5.0?

KingOfSquares avatar May 07 '20 22:05 KingOfSquares

I support this in principle. I think the best solution is to figure out a new keyword to replace "proto". Maps can use that keyword to define which OS PGM version they're using. Otherwise maps using legacy proto's will still work.

rafibaum avatar May 07 '20 22:05 rafibaum

IMO proto should be kept. Proto itself just needs to change for breaking changes, that means, if behaviour would change on an already made map without changes to it's xml, it should be a proto bump, that means new maps will work that way but older ones will keep working with the older behaviour.

Adding a new module doesn't mean bumping the proto, as long as any older map is not affected by it unless it's used.

OS PGM should just implement/backport up to proto 1.4.2 and continue from there if any breaking changes are added

Pablete1234 avatar May 07 '20 23:05 Pablete1234

We'll need to support both, so I think we can do this: proto is the old system. version is the new system, starting with 1.0

Electroid avatar May 07 '20 23:05 Electroid

To me, version seems to imply that one map made for one version would only work with one pgm version

Pablete1234 avatar May 07 '20 23:05 Pablete1234

My bigger issue with version is that it conflicts with the version tag already present in the XML files which refers to the version of the map itself.

rafibaum avatar May 08 '20 11:05 rafibaum

spec

kashike avatar Jun 03 '20 06:06 kashike

Surely we would want to keep everything in sync. Implementing 1.4.2 features should be the goal, maps are backwards compatible, and proto changes only happen for breaking things.

I don't think we should be encouraging spoons or future updates that brake legacy maps because they want to mess around with protocol versions.

Maybe I'm misunderstanding what issue is about. It should be assumed servers are running the latest plugin version and all new versions support previously valid maps.

Pugzy avatar Jun 08 '20 16:06 Pugzy