pcsx2
pcsx2 copied to clipboard
PCSX2
Qt/Patches: Get rid of the global WS/NI toggle
Description of Changes
This PR completely deprecates the Global WS/NI patches toggle so that the user would actually uses the patch section ~~like god intended.~~
Closes #10528
Rationale behind Changes
So users would use the patches section like intended instead of blindly enabling WS patches globally and risking breaking their game unintentionally.
Suggested Testing Steps
Check if the patches still works.
Will "[Widescreen 16:9]" still be required, or will we now be able to put the WS hacks into a tree with "[Widescreen\16:9]"?
will we now be able to put the WS hacks into a tree with "[Widescreen\16:9]"?
Patches section does NOT support grouping as far as I know.
Will "[Widescreen 16:9]" still be required, or will we now be able to put the WS hacks into a tree with "[Widescreen\16:9]"?
Patches don't support grouping, also there's no need to name the WS patches in a specific way anymore since you have to explicitly enable it in the first place.
If you press no, does pcsx2 annoy you every single time?
yes it does and thats idea, because the function are deprecated and aren't accessible anymore since the check boxes for it are gone. it also raises awareness for those who might not know the existence of the Patch section.
I understand one notification, but this ends up leading into the discussion of the user experience for those who use multiple pcsx2 versions.
You also don't check the value of it, if someone enables it, and then disables it months ago, they are going to get a notification for what purpose? I would argue the same for the original popup 🤷.
This dialog box runs literally no matter what if you haven't previously selected 'Yes'. You can show this by doing a completely fresh install of PCSX2 (in my case, I moved .config/PCSX2 elsewhere), and it will still tell you that you previously had these settings.
Now the prompt will only shows up once and will never prompt the user again once they press no.
I can confirm that it now no longer re-prompts after selecting 'no'. I can also confirm that it doesn't prompt me when the setting isn't there (I performed a fresh install of PCSX2 similar to before). Looks great to me!
One inconvenience of this commit is that for users who are used to turning on the 16:9 and no-interlacing patches by default, they need to set personalized settings for each game one by one.If a user has a thousand games, imagine what a huge workload this would be. Moreover, when opening a new game, users cannot intuitively observe the widescreen and no-interlacing patches that the game already has on the OSD.
For most gamers, widescreen and the deinterlacing patch seem to be the two options that must be selected if available. I think there is more positive value in keeping these two options.
One inconvenience of this commit is that for users who are used to turning on the 16:9 and no-interlacing patches by default, they need to set personalized settings for each game one by one.
this also solves people loading broken patches by default , it saves time in support requests
Moreover, when opening a new game, users cannot intuitively observe the widescreen and no-interlacing patches that the game already has on the OSD.
yes they can , gamesetting menu has the patch menu
this also solves people loading broken patches by default , it saves time in support requests
If one patch is broken,users can turn off this patch in the per-game personalization setting. But if you have two different monitors, one 4:3 and one widescreen, and want to quickly switch between the two display ratios, a common widescreen setting will greatly simplify the operation. Imagine if you have to change the settings of each game one by one to switch between widescreen and non-widescreen between thousands of games, what an exaggerated and massive operation it would be!
If one patch is broken,users can turn off this patch in the per-game personalization setting.
Except thats not how it works, the option literally blanket enables the patches regardless whether you have it enabled on the patches section or not.
Which leads to this situation:
But if you have two different monitors, one 4:3 and one widescreen, and want to quickly switch between the two display ratios, a common widescreen setting will greatly simplify the operation.
I don't see how having the global WS toggle help with multiple monitor situation.
Imagine if you have to change the settings of each game one by one to switch between widescreen and non-widescreen between thousands of games, what an exaggerated and massive operation it would be!
Okay that's just grossly exaggerated and massive skill issue on your end. and thats the idea of having the user explicitly enable the patches themselves, so it helps them be aware that a WS patch is enabled for thaat game.
After using the per game ws patches for a while instead of the global option I've realized I prefer this. So this is a welcomed change.
Thanks for added inconvenience.
You were free to join the discussion in a constructive manner.
It wasn't clear from a UX standpoint what that button actually did. It's evident from the many support requests we've received regarding its usage. If you have an actual argument against the removal of the global toggle, say it.
It wasn't clear from a UX standpoint what that button actually did. It's evident from the many support requests we've received regarding its usage. If you have an actual argument against the removal of the global toggle, say it.
Well, instead of toggling one toggle we now need to manually create/update patches for all of the games you want to play. Sure, I don't play thousands of games, but still it's just added inconvenience.
It wasn't clear from a UX standpoint what that button actually did. It's evident from the many support requests we've received regarding its usage. If you have an actual argument against the removal of the global toggle, say it.
Well, instead of toggling one toggle we now need to manually create/update patches for all of the games you want to play. Sure, I don't play thousands of games, but still it's just added inconvenience.
I initiated the discussion about it here: https://github.com/PCSX2/pcsx2/issues/12113
