pcsx2 icon indicating copy to clipboard operation
pcsx2 copied to clipboard

GS/HW: Add all levels/unclamped mipmap modes

Open stenzek opened this issue 1 year ago • 6 comments

Description of Changes

This PR brings back the mipmapping dropdown (oh noes), but it does not bring back basic (phew).

It adds two new modes:

All Levels

Instead of creating TC sources with LODs M..MXL, where M is the highest LOD from the vertex trace, it always uploads mip levels 0..MXL. This should have the result of producing fewer duplicate textures when dumping, and potentially increase TC efficiency, since there's less duplicates in the hash cache too.

Unclamped

This is a new, enhanced mode, that uses the full range of texture LODs that the game provides, but ignores the L/K values/game's bias. This results in higher-resolution textures being used when upscaling, and makes anisotropic filtering work again without requiring forced trilinear.

Rationale behind Changes

New enhancement for improved visuals in games, because forcing mipmapping everywhere was actually a visual regression in some cases.

Example: Burnout 3 image image

Suggested Testing Steps

Experiment :-)

stenzek avatar Jun 23 '24 12:06 stenzek

Appears to be a nice visual improvement across the board. Test Drive - Eve of Destruction_SLUS-20910_20240623162651 Test Drive - Eve of Destruction_SLUS-20910_20240623162721

CookiePLMonster avatar Jun 23 '24 14:06 CookiePLMonster

Fixes #11418 using All Levels.

JordanTheToaster avatar Jun 23 '24 16:06 JordanTheToaster

When booting a game OSD says Mipmapping is not set to Enabled/All Levels, even if it is. Actually, it seems that Pcsx2 general mipmapping setting doesn't work. Only changing it in game properties it does.

bigol83 avatar Jun 23 '24 19:06 bigol83

Are "Unclamped" and "Off" supposed to give different results? They gave me the same result in every game I tested.

DonelBueno avatar Jun 24 '24 12:06 DonelBueno

do you have an example GS Dump? and does it show differently with the normal mipmap setting?

refractionpcsx2 avatar Jun 24 '24 12:06 refractionpcsx2

Are "Unclamped" and "Off" supposed to give different results? They gave me the same result in every game I tested.

They are very much different.

image

JordanTheToaster avatar Jun 24 '24 12:06 JordanTheToaster

A good news, it performs very well in Need for Speed - Hot Pursuit 2 master: Need for Speed - Hot Pursuit 2_SLUS-20362_20240704184526 pr: Need for Speed - Hot Pursuit 2_SLUS-20362_20240704184615

As a price, the GPU overhead increased by 5%~8%

crashGG avatar Jul 04 '24 15:07 crashGG

I'm sad to see this PR has been closed.

crashGG avatar Jul 15 '24 16:07 crashGG

Could someone clarify why this PR was scrapped?

lextra2 avatar Jul 17 '24 22:07 lextra2