PeerBanHelper icon indicating copy to clipboard operation
PeerBanHelper copied to clipboard

调整部分规则订阅API返回message

Open PluieM opened this issue 1 year ago • 4 comments

PluieM avatar May 21 '24 12:05 PluieM

[!IMPORTANT]

Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar May 21 '24 12:05 coderabbitai[bot]

@Gaojianli 接口已添加至API 文档

PluieM avatar May 21 '24 12:05 PluieM

未来一周我将休假,无法进行开发工作,期待社区长出来


该邮件从移动设备发送

--------------原始邮件-------------- 发件人:"PluieM @.>; 发送时间:2024年5月21日(星期二) 晚上8:07 收件人:"PBH-BTN/PeerBanHelper" @.>; 抄送:"高渐离 @.>;"Mention @.>; 主题:Re: [PBH-BTN/PeerBanHelper] 调整部分规则订阅API返回message (PR #118)

@Gaojianli 接口已添加至API 文档

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

Gaojianli avatar May 21 '24 13:05 Gaojianli

好好休息  

Ghost_chu @.***

 

------------------ Original ------------------ From: @.>; Date: 2024年5月21日(星期二) 晚上9:27 To: @.>; Cc: @.***>; Subject: Re: [PBH-BTN/PeerBanHelper] 调整部分规则订阅API返回message (PR #118)

未来一周我将休假,无法进行开发工作,期待社区长出来


该邮件从移动设备发送

--------------原始邮件-------------- 发件人:"PluieM @.&gt;; 发送时间:2024年5月21日(星期二) 晚上8:07 收件人:"PBH-BTN/PeerBanHelper" @.&gt;; 抄送:"高渐离 @.&gt;;"Mention @.&gt;; 主题:Re: [PBH-BTN/PeerBanHelper] 调整部分规则订阅API返回message (PR #118)

@Gaojianli 接口已添加至API 文档

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.&gt; — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.>

Ghost-chu avatar May 21 '24 13:05 Ghost-chu

@PluieM API接口有点小问题:

  1. 这个接口里面的rule1是什么意思
  2. 更新订阅作为一个非幂等操作不应该使用get请求,考虑使用类似POST /api/sub/{ruleId}/update的接口,更新全部同理

Gaojianli avatar Jun 04 '24 11:06 Gaojianli

@PluieM API接口有点小问题:

  1. 这个接口里面的rule1是什么意思
  2. 更新订阅作为一个非幂等操作不应该使用get请求,考虑使用类似POST /api/sub/{ruleId}/update的接口,更新全部同理

1、rule1指ruleId,已调整api文档 2、已提交新的PR更正

PluieM avatar Jun 05 '24 10:06 PluieM