react icon indicating copy to clipboard operation
react copied to clipboard

Migrate demo build to also use rollup

Open jamesrweb opened this issue 4 years ago β€’ 9 comments

Currently the production build is ran through Rollup but the demo build is ran through Webpack for legacy reasons.

Webpack injects a lot of Webpack runtime specific things whereas Rollup does not. This being the case, it would be nice if we could also migrate the demo build process into its own Rollup configuration to replicate the current demo build functionality for benchmarking and alignment purposes.

This should benefit users running the live demo and developers working on local examples to get quicker load times and smaller development bundles.

jamesrweb avatar Sep 09 '21 20:09 jamesrweb

@yevdyko created the issue πŸ‘ŒπŸ». Do you feel up to implementing and benchmarking this one to validate the outlined assumptions, etc?

jamesrweb avatar Sep 09 '21 20:09 jamesrweb

@jamesrweb I don't mind replacing to get rid of unnecessary dependencies, but benchmarking sounds like overhead as there is no real need for this comparison.

yevdyko avatar Sep 09 '21 20:09 yevdyko

@yevdyko Either way the end result is faster and more efficient output so if you can work on that then I'd appreciate it πŸ™

jamesrweb avatar Sep 09 '21 22:09 jamesrweb

@yevdyko any updates for this one? πŸ˜„

jamesrweb avatar Feb 19 '22 22:02 jamesrweb

@jamesrweb I finally got around to it and am now working on this migration.

yevdyko avatar Mar 20 '22 11:03 yevdyko

@yevdyko nice! Very excited for this one! πŸ₯³

jamesrweb avatar Mar 20 '22 13:03 jamesrweb

@yevdyko any updates here? ☺️

jamesrweb avatar May 05 '22 18:05 jamesrweb

Hi @yevdyko, is everything okay with this one? Anything I can support with or is it just a question of time? All good if it is, just wondering how things are going or if there's a plan in place, really looking forward to seeing your work on this one πŸ˜„πŸ‘πŸ»!

jamesrweb avatar Jul 25 '22 08:07 jamesrweb

Hi @yevdyko, is everything okay with this one? Anything I can support with or is it just a question of time? All good if it is, just wondering how things are going or if there's a plan in place, really looking forward to seeing your work on this one πŸ˜„πŸ‘πŸ»!

I'm going to change a few things in the config today, and then it will be ready for review and your feedback

yevdyko avatar Sep 12 '22 08:09 yevdyko

Closing due to inactivity. Will raise a new issue as a replacement.

jamesrweb avatar Mar 18 '23 01:03 jamesrweb