Minecraft-Hack-BaseClient icon indicating copy to clipboard operation
Minecraft-Hack-BaseClient copied to clipboard

[BUG REPORT] Full module settings implementation for List<String> not added yet.

Open ghost opened this issue 4 years ago • 8 comments
trafficstars

Describe the bug When adding a setting of the type List<String>, I cannot scroll through the settings on the TabGUI like I normally would for any other client using the same type of setting.

To Reproduce In a setup() method of a module, paste this code in:

List<String> modeVals = new ArrayList();
modeVals.add("java math");
modeVals.add("bhop");

moduleSettings.addDefault("mode", modeVals);

Expected behavior To be able to scroll through the list of String settings I added.

Screenshots If applicable, add screenshots to help explain your problem.
pain

Stack Trace Add the error stack trace, if any.

Versions:

  • OS: Windows 10
  • Java: JDK 11
  • IDE: Eclipse
  • Commit / Release: Custom build using the same Config/ModuleSetting base as the latest commit (as of now, the latest commit is 74bf707dbd97df40812e59a2e76f1a9a6abb65c8 ). My custom build can be found at Keol-ClientBase.

Additional context Add any other context about the problem here.
pain

ghost avatar Aug 21 '21 00:08 ghost

Unfortunately the ClickGui that is currently released is not final or complete. I'm working on a re-design but it's taking longer than anticipated. It will be released in the near future, though

OxideWaveLength avatar Aug 21 '21 07:08 OxideWaveLength

Unfortunately the ClickGui that is currently released is not final or complete. I'm working on a re-design but it's taking longer than anticipated. It will be released in the near future, though

can i merge my clickgui then? :trol:

ghost avatar Aug 21 '21 14:08 ghost

Have you made the whole thing yourself?

OxideWaveLength avatar Aug 21 '21 14:08 OxideWaveLength

Have you made the whole thing yourself?

the "design" is new, but the entire base is skidded from yours :)

ghost avatar Aug 21 '21 14:08 ghost

Oh, then I don't see why not, just fork the repository and create a PR, I will look at it later today 😄

OxideWaveLength avatar Aug 21 '21 14:08 OxideWaveLength

just a question: do you have a gitignore for mcp files?

or should i merge my gitignore too

ghost avatar Aug 21 '21 14:08 ghost

I don't, but it's not needed as the repository is inside of MCP's "minecraft" folder itself Should be at least

OxideWaveLength avatar Aug 21 '21 14:08 OxideWaveLength

okay pr open

ghost avatar Aug 21 '21 17:08 ghost