OwnageIsMagic

Results 64 comments of OwnageIsMagic
trafficstars

`AutoCompleteOnSuccess` property is also not persisted. Add notice about it in documentation.

See also https://github.com/dahall/Vanara/issues/311#issuecomment-1237552348 (for https://github.com/dahall/Vanara/commit/77f8ca176e9424d845a3abfff82d97d1ee81b7d8#diff-447817cf86df18256de9c8b3e0e78afd27d6c9a878e9d8a0bd34efaa915e023fR38) and https://github.com/dahall/Vanara/commit/74bbe0f933cd27011c328f136ae952b53e97b03b#r84756352 / https://github.com/dahall/Vanara/commit/74bbe0f933cd27011c328f136ae952b53e97b03b#r84758117

hmm, I'm sorry, but there is one more case. move [NotifyFlags = 0;](https://github.com/dahall/Vanara/blob/e9d57433b4d9b5cef76039cefd19abff8f0a60fe/BITS/BackgroundCopyJob.cs#L831) inside `if (m_notifier is not null` (it calls `m_ijob.SetNotifyFlags(value)` in setter) And could you make [this constructor](https://github.com/dahall/Vanara/blob/e9d57433b4d9b5cef76039cefd19abff8f0a60fe/BITS/BackgroundCopyJob.cs#L990)...

Seems like it used for [command line notification](https://learn.microsoft.com/en-us/windows/desktop/api/bits1_5/nf-bits1_5-ibackgroundcopyjob2-setnotifycmdline) too, so you should not override it with 0 at all (and make it public).

`SetNotifyInterface`/`SetNotifyFlags` are intrusive and machine wide, so we can assume there is only one instance of `BackgroundCopyJob`. You can just read notifyFlags in ctor and restore this state in Dispose....

oh I missed a word user subscribes **and unsubscribes** to Error and Completed (so NotifyFlags is now 0 and cmd is not called)

I usually unsub from all events cause sometimes it's hard to tell would subscriber outlive event source or not.

Metadata filters https://www.youtube.com/watch?v=MBvAvW6KQDk&list=PLRO4b8EqD8g5ptqAPiMnrnslZPIK70V44&index=7 have all songs ending wih `- Solo Guitar` I want to remove it

The best approach is to be able to configure used filters dynamically

Something with checkboxes where I can enable each filter individually or disable all post processing