Outternet comments

Results 26 comments of


                                            Outternet

lib/strategy: Add failWithError support

Could you elaborate on your idea, as I currently agree with the rest of the comments.

Provide own jwt-verify option

Current not unfortunately as you said current driver `jsonwebtoken` hardcoded. However, this functionality is available in rewrite where jose has an abstrate driver and the jwk can be passed directly.

adding Promise handling to jwtFromRequest result, type checking on result and error handling for new functionality.

This is a good idea, I have adopted your implemetation in the major rewrite pull request.

Throw a named error instead of a generic error, when no auth token is provided

This is a good point, either error classes (wich is against the offical passport documentation) or error messages should be put in an enum. Please add a PR (if you...

"TypeError: JwtStrategy requires a secret or key" with NestJS

@VividLemon this is not correct `@nestjs/jwt` does accept the `secret` param, the `passport-jwt` library on the other side does not and this should be replaced with `secretOrKey`.

Extractor jwtFromRequest should be made asynchronous

implemented in rewrite.

Disallow None algorithm by default

thanks for your analysis this has helped me, the simplest migration seems to me a standard algorithm (other than `none`)

Passport-jwt extractor fromUrlQueryParameter don't handle handshake requests (websocket)

the library expects an http req object. the rewrite avoids these depencies by adding more validation. Again this could have been implemented with a custom extractor instead of a patch,...

Adding callbacks to options param.

Please elaborate why that is, because in its current state it can be used for multiple requests (that is the purpose of passport). Do you mean multiple strategies because then...

Implementation of Cookie Extractor

This is a good idea, I have adopted your implemetation in the major rewrite pull request.