django-nested-inline icon indicating copy to clipboard operation
django-nested-inline copied to clipboard

Update .field-box => .fieldBox

Open leibowitz opened this issue 5 years ago • 4 comments
trafficstars

The admin CSS class field-box is renamed to fieldBox to prevent conflicts with the class given to model fields named “box”.

https://docs.djangoproject.com/en/3.0/releases/2.1/#miscellaneous

leibowitz avatar Apr 02 '20 10:04 leibowitz

How does this affect Django versions before 2.1?

OskarPersson avatar Apr 02 '20 12:04 OskarPersson

I assume it won't work, as in regression and result in no style applied (using whatever the default was) I would vote for doing the change and losing compatibility for django <2.1 in a new version, personally. Otherwise the only way to make this work for both would to be duplicate the style and keep the field-box, but as django realised, this is not the best way since it could be applied to a field called 'box' (hence why it was renamed)

leibowitz avatar Apr 02 '20 12:04 leibowitz

I've created an alternative PR that only adds the style, rather than just updating it (to keep backward compatibility): https://github.com/s-block/django-nested-inline/pull/114 Feel free to decide which one is best, and close the other one.

leibowitz avatar Apr 02 '20 13:04 leibowitz

Any updates?

leibowitz avatar Apr 30 '20 09:04 leibowitz