origin-dollar icon indicating copy to clipboard operation
origin-dollar copied to clipboard

bulk exit and remove validator

Open naddison36 opened this issue 1 year ago • 3 comments
trafficstars

Changes

  • Changed exit and remove validators to be bulk functions so multiple validators can be exited or removed in a single tx

Dependencies

The is to be deployed with

  • https://github.com/OriginProtocol/origin-dollar/pull/2179

Code Change Checklist

To be completed before internal review begins:

  • [ ] The contract code is complete
  • [ ] Executable deployment file
  • [ ] Fork tests that test after the deployment file runs
  • [ ] Unit tests *if needed
  • [ ] The owner has done a full checklist review of the code + tests

Internal review:

  • [ ] Two approvals by internal reviewers

naddison36 avatar Aug 12 '24 07:08 naddison36

Warnings
:warning: :eyes: This PR needs at least 2 reviewers

Generated by :no_entry_sign: dangerJS against e4ef7cb27155ea8de09f8fc7356696279c380d9e

github-actions[bot] avatar Aug 12 '24 07:08 github-actions[bot]

Codecov Report

:x: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 37.97%. Comparing base (a64f644) to head (e4ef7cb). :warning: Report is 1 commits behind head on nicka/pectra.

Files with missing lines Patch % Lines
.../strategies/NativeStaking/ValidatorRegistrator.sol 0.00% 24 Missing :warning:
Additional details and impacted files
@@               Coverage Diff                @@
##           nicka/pectra    #2185      +/-   ##
================================================
- Coverage         38.01%   37.97%   -0.05%     
================================================
  Files               121      121              
  Lines              5664     5670       +6     
  Branches           1501     1501              
================================================
  Hits               2153     2153              
- Misses             3509     3515       +6     
  Partials              2        2              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Aug 12 '24 07:08 codecov[bot]