redbird icon indicating copy to clipboard operation
redbird copied to clipboard

Add CORS handling in the proxy

Open dieppe opened this issue 11 years ago • 11 comments

Hi,

Thanks for the great work on redbird, we've been using it in production for about 2 weeks, and we're quite happy with it :beers:, especially the HTTPs support is great!

The only problem we had, that is more an annoyance than a bug, is that we had to disable redirect because it is not compatible with CORS, since the 302 headers do not have any CORS information.

Would it be possible to add support for CORS inside redbird? That would be most appreciated (and useful).

Thanks!

dieppe avatar Oct 06 '14 15:10 dieppe

ok, I will look into it.

manast avatar Oct 06 '14 15:10 manast

I will integrate this library: https://github.com/troygoode/node-cors in redbird for complete CORS support.

manast avatar Oct 07 '14 08:10 manast

Thank you for your quick answer. I think the most important bit is CORS preflight (at least for http -> https redirect).

dieppe avatar Oct 07 '14 13:10 dieppe

Sorry, I was wrong, I think preflight has nothing to do with http to https redirect.

dieppe avatar Oct 14 '14 14:10 dieppe

+1

cgarvis avatar Feb 12 '15 16:02 cgarvis

Hi @manast .

Just wanted to know if this issue will be implemented soon ?

if any help needed - just say .

best regards, elad.

eladh avatar Sep 14 '16 17:09 eladh

@eladh I do not have the requirement myself so I do not really know where to start :) You are welcome to help if you want to.

manast avatar Sep 14 '16 18:09 manast

the readme says there is cors support but there isn't. any updates on this?

joernroeder avatar Nov 12 '20 16:11 joernroeder

Any progress on this? 👀

Just want to add Access-Control-Allow-Origin: * to all requests

lopugit avatar Mar 18 '24 00:03 lopugit

Screenshot 2024-03-18 at 11 54 58 am

RIP 😂

lopugit avatar Mar 18 '24 00:03 lopugit

time for a PR 💪

lopugit avatar Mar 18 '24 00:03 lopugit