GWSL-Source icon indicating copy to clipboard operation
GWSL-Source copied to clipboard

Dashboard Empty When HDR Enabled.

Open JerrettDavis opened this issue 4 years ago • 20 comments

On a fresh install with Windows 10 Pro Build 21364.co_release.210416-1504, opening the dashboard only renders the backdrop. It appears the buttons are present and clickable, but there's no text or images rendered on the backdrop. Even more interesting, when attempting to take a screenshot, the text IS visible!

image

JerrettDavis avatar Apr 24 '21 21:04 JerrettDavis

I think you have hdr enabled. The way to go around this is to right click the gwsl icon, click Configure GWSL, and change acrylic_enabled to false instead of true. Then save. This is less pretty but I could not find another workaround

Pololot64 avatar Apr 24 '21 21:04 Pololot64

I think you have hdr enabled. The way to go around this is to right click the gwsl icon, click Configure GWSL, and change acrylic_enabled to false instead of true. Then save. This is less pretty but I could not find another workaround

Looks like that solves the problem. Shame I lose out on the acrylic though. Thanks.

JerrettDavis avatar Apr 24 '21 22:04 JerrettDavis

:( Maybe I can change it to a picture or color other than black in the next update

Pololot64 avatar Apr 24 '21 22:04 Pololot64

It's not a major issue, but maybe you can default to acrylic being off for new installations, with an Enable Acrylic option somewhere in the install wizard, or in the dashboard itself. That said, this is the first app, I've encountered rendering issues from with HDR enabled, I'm curious if it's coming from the underlying libraries, or if there's something more funky going on.

JerrettDavis avatar Apr 24 '21 23:04 JerrettDavis

Part of it has to do with the fact that GWSL is written in python so I had to get real hacky about supporting acrylic. I don't want it to be disabled by default but maybe I can find a way to detect if hdr is on. I have not found it in the registry yet though

Pololot64 avatar Apr 24 '21 23:04 Pololot64

I'm sure it's not entirely ubiquitous, but it seems Computer\HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\VideoSettings\EnableHDRForPlayback is a good starting point to detect HDR.

JerrettDavis avatar Apr 24 '21 23:04 JerrettDavis

Maybe. I need to find an hdr display to test.. The other variables that exist for the same thing perplex me though. The registry is amazingly inconsistent between machines.

Pololot64 avatar Apr 24 '21 23:04 Pololot64

Well, I happen to have several HDR displays to test with, so if you have any experimental builds, please send them my way, and I'd be happy to give them a go.

JerrettDavis avatar Apr 24 '21 23:04 JerrettDavis

I can do that. Now I have to mess with the registry to find the real variable if it exists (because the one you mentioned is set to 1 on my pc and I don't have the problem)

Pololot64 avatar Apr 24 '21 23:04 Pololot64

And I can do a pretty good "fake acrylic" with the background image image

Pololot64 avatar Apr 24 '21 23:04 Pololot64

I noticed you're down in Dallas, I'm just north of you in Tulsa, OK. If you'd send me an email or a DM me on twitter at @JDDavisPro, I'm happy to give you an HDR display to test with.

As for the registry key, it's a bit misleading. Even if it's set to 1 on your local machine, it won't enable HDR unless windows detects an HDR compatible display. Disabling HDR on my displays (with the registry key set to 1) corrects the issue entirely, but obviously that's not optimal.

JerrettDavis avatar Apr 24 '21 23:04 JerrettDavis

Yeah. And thanks that is very thoughtful but I know someone I can borrow one from. ;)

Pololot64 avatar Apr 24 '21 23:04 Pololot64

Sounds good. Feel free to close the issue (or tag it for future reference). I'm able to use the app with acrylic disabled, and that's what matters most.

JerrettDavis avatar Apr 24 '21 23:04 JerrettDavis

👍I will keep it open for a bit though so it can benefit others. I will follow up in a few days or so if I find a fix or have a better build

Pololot64 avatar Apr 24 '21 23:04 Pololot64