front-end icon indicating copy to clipboard operation
front-end copied to clipboard

Limit width of page content to match width of nav bar

Open toadkicker opened this issue 3 years ago • 8 comments
trafficstars

For example, there is text well into the gutters of the branding page, and those gutters are not equal sizes. Screen Shot 2022-05-31 at 10 41 36 AM

toadkicker avatar May 31 '22 17:05 toadkicker

This is expected. The nav isn't meant to flag the existence of a gutter. I'm not a designer. I just implemented mocks I received.

kylemh avatar May 31 '22 18:05 kylemh

@kylemh does this help to re-open the issue? Branding-Page-MockUp

datphotogurl avatar May 31 '22 19:05 datphotogurl

No, I'm not sure what's being said. There exist dozens of pages where the nav width isn't the guide for gutters. Content spans past that width on many instances.

kylemh avatar May 31 '22 19:05 kylemh

I think that is a bug not a requirement

toadkicker avatar May 31 '22 19:05 toadkicker

What I'm saying is this specific UI spans past the nav, but it also does on many pages because it's not related.

That doesn't mean we can't fix the UI. It also doesn't mean we can't fix only THIS UI.

I only had context that you were reporting these issues as a helpful bypasser. If @datphotogurl wants this UI changed in some way, I'll do so!

kylemh avatar May 31 '22 19:05 kylemh

I believe Todd was just making helpful suggestions. If the CSS width spans on all of the pages, could we fix that for all the pages?

datphotogurl avatar May 31 '22 19:05 datphotogurl

Not simply, but it's certainly something we can explore.

kylemh avatar May 31 '22 20:05 kylemh

edited title and OP and reopened issue

kylemh avatar May 31 '22 20:05 kylemh

is this issue still available to work on ?

aashmanVerma avatar Oct 16 '22 03:10 aashmanVerma

Yes, but I don't think it will be a simple issue - just a heads up!

kylemh avatar Oct 16 '22 14:10 kylemh

Yes, but I don't think it will be a simple issue - just a heads up!

I see that the nav has a max-width of 1200px, but not seeing any other sections of content (or content) with that constraint. Are you thinking there would need to be changes for each page, or possibly even each section of content?

recondesigns avatar May 14 '23 06:05 recondesigns

The Container component (which is omnipresent) has a max-width of 1400px.

The difficulty in this ticket is that there are MANY components that have arbitrarily set max-widths. The solution won't be just changing Container and/or Nav.

kylemh avatar May 14 '23 17:05 kylemh