robotframework-can-uds-library
robotframework-can-uds-library copied to clipboard
Padding of transmitted isotp messages simplifies usage
Many thanks for the great library, which saves us a lot of time.
During a proof of concept we stumbled upon a problem, which could be only resolved by changing the Curf.py a bit.
Can you please change the following line in Curf.py on line 213, so that messages not fitting an 8 Byte Can-Frame are automatically filled up with padding bytes:
self.isotp_stack = isotp.CanStack(
bus=self.bus,
address=self.isotp_addr,
error_handler=self.curf_error_handler,
params = {"tx_padding":0x55})
@Frankyboy100880
Can you send a Pull Request containing your patch ?
Best regards, Romain
I'm unable to push a new branch to this repo. Am I allowed to do so? Can I create a branch here with the Web frontend of GitHub?
I tried it directly, but there are problems with my credentials:
$ git push --set-upstream origin Hotfix/AddPadding
remote: Permission to Openwide-Ingenierie/robotframework-can-uds-library.git denied to Frankyboy100880.
fatal: unable to access 'https://github.com/Openwide-Ingenierie/robotframework-can-uds-library.git/': The requested URL returned error: 403
@Frankyboy100880
The github process to send a Pull Request is:
- fork the upstream repository to your github account
- push your branch you want to contribute
- create a Pull Request from you account to the upstream repo.
https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork
Thanks for the help. I created a pull request for my issue.