openzeppelin-test-helpers icon indicating copy to clipboard operation
openzeppelin-test-helpers copied to clipboard

Published 20 hours ago • verified publisher icon OpenZeppelin

hope this project can continue

Open fjun99 opened this issue 3 years ago • 3 comments

The helper in this project is very helpful.

Maybe we can continue to develop this project:

  • migrate it to ethers.js
  • add new handy helpers

fjun99 avatar Feb 21 '22 14:02 fjun99

Hi @fjun99. Personally I feel this project needs to be rewritten from scratch in TypeScript, and that it should be compatible with Ethers.js as well as Web3.js and Truffle. It should also have a lot fewer dependencies, particularly someone working with Ethers.js should not have to install Web3.js or Truffle and vice versa.

The testing setup is slow and overly complicated. I don't think we need to have this many integration tests.

If someone wants to work on this, that would be awesome.

frangio avatar Feb 22 '22 21:02 frangio

Hi @fjun99. Personally I feel this project needs to be rewritten from scratch in TypeScript, and that it should be compatible with Ethers.js as well as Web3.js and Truffle.

yes I agree. Typescript and ethers.

I adapted one or two js file in this project to ts for my own usage.

to work with

  • ethers.js
  • hardhat

fjun99 avatar Feb 28 '22 15:02 fjun99

I have started a potential rewrite of the project. So far expectRevert and snapshot are built. I would propose as next step expectEvent.

https://github.com/OpenZeppelin/openzeppelin-test-helpers/tree/rewrite

frangio avatar Mar 04 '22 22:03 frangio