openzeppelin-contracts icon indicating copy to clipboard operation
openzeppelin-contracts copied to clipboard

Grouping the extension access control contracts into one `extensions/` folder

Open 0xisk opened this issue 3 years ago • 2 comments
trafficstars

🧐 Motivation I think grouping the extension access control contracts would be more readable and organized, as it happens with the token standard contracts.

📝 Details

Current structure:

contracts   
│
└─── access
    │   AccessControl.sol
    │   AccessControlCrossChain.sol     "Extension contract"
    │   AccessControlEnumerable.sol    "Extension contract"
    │   IAccessControlEnumerable.sol   "Extension contract interface"
    │   ...
    └───

Expected structure:

contracts   
│
└─── access
     │
     └─── extensions
     │    │   AccessControlCrossChain.sol     "Extension contract"
     │    │   AccessControlEnumerable.sol    "Extension contract"
     │    │   IAccessControlEnumerable.sol   "Extension contract interface"
     │    └───
     │   AccessControl.sol
     │   ...
     └───

0xisk avatar Jul 27 '22 08:07 0xisk

As discussed in the original PR, this would be a breaking change as far as the import paths are concerned. Suggest we put that in the 5.0 roadmap

Amxx avatar Jul 27 '22 13:07 Amxx

Thanks, @Amxx I just wanted to log it here as discussed so you can discuss with the team it later milestone.

0xisk avatar Jul 27 '22 14:07 0xisk

@Amxx any updates, can a PR be submitted for it?

balajipachai avatar Jun 08 '23 07:06 balajipachai