openzeppelin-contracts icon indicating copy to clipboard operation
openzeppelin-contracts copied to clipboard

Published 20 hours ago • verified publisher icon OpenZeppelin

Procedurally generate EnumerableSet and EnumerableMap

Open Amxx opened this issue 3 years ago • 2 comments

PR Checklist

  • [x] Tests
  • [ ] Documentation
  • [ ] Changelog entry

Amxx avatar May 23 '22 10:05 Amxx

Now that we have gas reporting, with this PR it should be easy to compare the cost of our current approach (cast everything to a Bytes32Set) versus duplicating the code for every type.

frangio avatar Jul 21 '22 23:07 frangio

We discussed that, and casting, while not being a breaking change on the solidity side would not be supported by the upgrades plugin.

I would do this PR in 4.X, and then do the change for casting (depending on the gas outcome) in 5.0

Amxx avatar Jul 25 '22 19:07 Amxx

I love everything about this

nventuro avatar Aug 19 '22 23:08 nventuro