cairo-contracts icon indicating copy to clipboard operation
cairo-contracts copied to clipboard

Published 20 hours ago • verified publisher icon OpenZeppelin

Add deployer preset

Open martriay opened this issue 3 years ago • 4 comments

Fixes #384. This PR also centralizes IACCOUNT_ID across tests in tests/utils.py.

Current UniversalDeployerContract implementation results in address 0x414aa016992e868fa22e21bd104757e280c83ecb260fe9bccd1caee2f7f590e if deployed from zero.

martriay avatar Sep 13 '22 03:09 martriay

This is in the utils/constants directory. Is that intentional? The category seems wrong to me.

frangio avatar Sep 13 '22 15:09 frangio

This is in the utils/constants directory. Is that intentional? The category seems wrong to me.

It was wrong, thanks.

martriay avatar Sep 13 '22 16:09 martriay

I'm not sure. On one hand I wouldn't rush releasing this feature, on the other I'm uncertain of how documented it should be. I'm not sure if it's meant to be used for users either, I just thought having it in the library would make sense for standardization purposes, and probably aid tooling (i.e. the devnet taking this implementation to pre-deploy an UDC so it's available).

Thoughts?

martriay avatar Sep 24 '22 13:09 martriay

Hm yeah, I agree. I suppose if later on we decide to include it or some mention of it, we can just point to the proposal in Shamans

andrew-fleming avatar Sep 24 '22 18:09 andrew-fleming