cairo-contracts icon indicating copy to clipboard operation
cairo-contracts copied to clipboard

Published 20 hours ago • verified publisher icon OpenZeppelin

Enumerable map & set

Open koloz193 opened this issue 3 years ago • 7 comments

Fixes #196. Added in felt based enumerable set and map with supporting tests. This assumes that the implementing contracts keep track of a set id or map id (see the mocked classes).

koloz193 avatar Mar 30 '22 21:03 koloz193

@andrew-fleming should be good to review now!

koloz193 avatar May 03 '22 03:05 koloz193

Very good work! Left some comments and suggestions. Also, please add documentation for the feature :)

yea thats a good idea. ill add in some docs :)

koloz193 avatar May 07 '22 14:05 koloz193

Hey, @koloz193! Just checking in. Will you be able to address the requested changes in the next few days? No pressure! If you can't get to it, we'll pick this and ERC20_Burnable up and finish them :)

andrew-fleming avatar Jun 14 '22 23:06 andrew-fleming

@andrew-fleming yup getting to both this weekend

koloz193 avatar Jun 15 '22 20:06 koloz193

@andrew-fleming added the params and fixtures to the set tests, for the map i didnt feel like it cut down on enough

koloz193 avatar Jun 24 '22 19:06 koloz193

@andrew-fleming @martriay any update on this 😄

koloz193 avatar Jul 13 '22 15:07 koloz193

This is currently on our project roadmap, just that it's prioritized as "Low". This means we will tackle it whenever we finish higher priority issues, or we reprioritize based on new information. Sorry it's taking so long 🙇.

martriay avatar Jul 13 '22 17:07 martriay

Closing this since it's severely outdated. I'm really sorry @koloz193 we never got to prioritize it :(

martriay avatar Nov 10 '23 06:11 martriay