raven icon indicating copy to clipboard operation
raven copied to clipboard

Add media reference to inspector

Open jspada200 opened this issue 1 year ago • 6 comments

This is a Work-In-Progress Pull Request meant to solve: https://github.com/OpenTimelineIO/raven/issues/62

Changes

Main Changes:

  • Add new section to inspector to view and modify Media References
  • Supports MissingMediaReference, ExternalReference, and ImageSequenceReference classes
  • Add attributes for:
    • Available Image Bounds
    • Available range
    • Target/Target URL base
    • Selected media reference
    • Metadata

Minor Changes:

  • Vscode is changing the import order of implot
  • Added the vscode config file to the gitignore for anyone else using vscode

Examples:

2024-09-27 11 49 53

2024-09-27 11 49 00

jspada200 avatar Sep 27 '24 18:09 jspada200

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: Jspada200ilm / name: jspadafora (87a4f46bab8de90bc60a5dba112db63406c04a54)

If you click the "Details" link next to the DCO and EasyCLA checks, there are instructions on how to get those resolved. Let us know if you get stuck or have questions about those.

jminor avatar Sep 27 '24 22:09 jminor

If you click the "Details" link next to the DCO and EasyCLA checks, there are instructions on how to get those resolved. Let us know if you get stuck or have questions about those.

Thanks, I was able to figure out the DCO but my manager had me submit my name for the CLA. I am just waiting for them to let me know what needs to be done.

Thanks!

jspada200 avatar Oct 01 '24 17:10 jspada200

Ok, great. Let us know if there are questions about the CLA. I know some organizations can take a while to get those signed.

jminor avatar Oct 01 '24 20:10 jminor

Just to follow up on this. Turns our that ILM does not have the CLAs setup for OTIO and needs to go through the process of getting those with Legal so it will be a bit longer this this and other PRs from ILM can be merged. Going to leave this PR open for now and stay on top of things here.

Thanks!

jspada200 avatar Oct 16 '24 17:10 jspada200

FYI.... Still waiting on CLA....

jspada200 avatar Jan 20 '25 18:01 jspada200

@jspada200 any update on the CLA?

timlehr avatar May 16 '25 07:05 timlehr

@jspada200 any update on the CLA?

Still waiting 8 / on Legal/Security review.... Maybe my Open source days contribution this year will be resolving the merge conflicts and getting this in XD

jspada200 avatar May 16 '25 16:05 jspada200

@jspada200 I believe the CLA has been signed now. Would you mind rebasing onto the latest main to see if the EasyCLA check will pass now?

jminor avatar Jul 28 '25 19:07 jminor

@jspada200 I confirmed that you are on the approved contributors list now. There are two steps remaining:

  • You need to let GitHub know that you accept being added to that list: https://docs.linuxfoundation.org/lfx/easycla/v2-current/contributors/corporate-contributor#acknowledge-company-contribution
  • You'll need to update some of your commits so they are all authored by the same email address, or just squash them into one. Let me know if you need help with either of those. We're almost got this finished :)

jminor avatar Aug 22 '25 21:08 jminor

Thanks @jminor , Will give this a shot this week!

jspada200 avatar Aug 25 '25 16:08 jspada200

I am not sure what is going on with the jspada200 and jspada200ilm account on github... Trying to figure it out so we can get passed this CLA thing! I did ask our CTO to approve the CLA again for jspada200....

jspada200 avatar Aug 25 '25 18:08 jspada200

Some users are added to EasyCLA via their email vs their GitHub username. With the email, I'm not sure if that needs to match the email in each commit or the email on your GitHub user settings, or maybe both. I suspect that entering your GitHub username into EasyCLA would make it happy.

jminor avatar Aug 25 '25 19:08 jminor

Some users are added to EasyCLA via their email vs their GitHub username. With the email, I'm not sure if that needs to match the email in each commit or the email on your GitHub user settings, or maybe both. I suspect that entering your GitHub username into EasyCLA would make it happy.

We did it @jminor !

jspada200 avatar Aug 25 '25 19:08 jspada200

Woohoo! Thanks for the perseverance @jspada200 - the next one will be easier :)

jminor avatar Aug 27 '25 00:08 jminor