better-srcds-log-parser icon indicating copy to clipboard operation
better-srcds-log-parser copied to clipboard

Add a script to build

Open smartpierre opened this issue 8 years ago • 4 comments
trafficstars

Hi,

I have forked your project and I'm changing a few things in the code. However, there's no command in package.json to build the .ts files into .js could you please add it or document the way you do it ?

Thanks !

smartpierre avatar Nov 09 '17 10:11 smartpierre

Hey Pierre,

A few ways. The typescript compiler should be installed as a dependency. So you can run something like node_modules/typescript/bin/tsc and it will build using the config file in the project root. The path might be wrong, that's from memory and I'm not in front of my computer at the moment.

If you install typescript globally with npm install -g typescript then you can just use tsc at the command line.

I'll update the script when I get some time at home over the weekend. If you get it working, please consider submitting a pr :)

On 9 November 2017 9:08:35 pm AEDT, "Pierre D." [email protected] wrote:

Hi,

I have forked your project and I'm changing a few things in the code. However, there's no command in package.json to build the .ts files into .js could you please add it or document the way you do it ?

Thanks !

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSourceLAN/better-srcds-log-parser/issues/2

sirsquidness avatar Nov 09 '17 12:11 sirsquidness

It was just pointed out in a discord discussion that I didn't put the correct dependencies in package.json. whoops! Sorry :)

You need typescript to compile, and typings to download some TS types files. Install both packages globally I guess, then run typings install, then tsc, and that should get you building I think

On 9 November 2017 9:08:35 pm AEDT, "Pierre D." [email protected] wrote:

Hi,

I have forked your project and I'm changing a few things in the code. However, there's no command in package.json to build the .ts files into .js could you please add it or document the way you do it ?

Thanks !

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/OpenSourceLAN/better-srcds-log-parser/issues/2

sirsquidness avatar Nov 09 '17 13:11 sirsquidness

I just published a branch with the build scripts in it, and another fix. Check out the branch https://github.com/OpenSourceLAN/better-srcds-log-parser/tree/support-http-logs for more info and let me know if that helps you.

sirsquidness avatar Nov 10 '17 23:11 sirsquidness

That's awesome ! Thank you for the quick response, I'll try it :)

smartpierre avatar Nov 14 '17 13:11 smartpierre