Windows Release Guide suspicious instruction

[jan-cerny]

https://github.com/OpenSCAP/scap-workbench/wiki/Windows-build-and-installer-guide

Section 2. Compile SCAP Workbench suggests the following:

In case you get an error regarding something like #include_next<stdlib.h>, change this line to #include<stdlib.h> in the file cstdlib

I know it helps, but I find weird to edit compilers header files. I think headers should not be touched by user.

I think we might miss some definition on compiler flag.

[matejak]

This is indeed a weird instruction. Could you try to clean, configure and build again, passing additional -DENABLE_PRECOMPILED_HEADERS=OFF to cmake in the configure phase?

[yuumasato]

Changing #include_next to #include was the last measure used after some time trying to resolve compilation problem. -DENABLE_PRECOMPILED_HEADERS=OFF is a good try.

[mpreisler]

I agree that that note is really confusing.

I really wish the wiki had all the info. This is about an upstream issue in cstdlib, in the version used by mingw32 on fedora. This has more info: https://stackoverflow.com/questions/45245923/mingw-include-c-cstdlib-stdlib-h-no-such-file-or-directory

It could very well be that this has been fixed and we can remove this whole note.

[redhatrises]

I have made updates to this on the wiki. Just need someone to validate the changes.