osrd icon indicating copy to clipboard operation
osrd copied to clipboard

front: fix space time chart when first or last waypoint are hidden

Open SharglutDev opened this issue 1 year ago • 1 comments

Filter data from projected path (path and occupancy blocks) and conflicts when the first or last waypoint is hidden. Allow the space time chart to look as if it started/ended with the first/last displayed waypoint.

part of #8628 (see last comment of the issue)

before : Capture d’écran 2024-10-29 à 16 46 57

after : Capture d’écran 2024-10-29 à 16 46 24

To test :

  • Add at least 2 trains with only 1min difference for departure time
  • With the waypoints panel, hide the first x waypoints and/or the last x waypoints

SharglutDev avatar Oct 29 '24 15:10 SharglutDev

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 17.59259% with 89 lines in your changes missing coverage. Please review.

Project coverage is 41.81%. Comparing base (0e1ea9b) to head (6954523). Report is 14 commits behind head on dev.

Files with missing lines Patch % Lines
...WithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx 0.00% 81 Missing and 1 partial :warning:
...nResult/components/SpaceTimeChart/helpers/utils.ts 73.07% 0 Missing and 7 partials :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9513      +/-   ##
============================================
- Coverage     42.51%   41.81%   -0.70%     
  Complexity     2271     2271              
============================================
  Files          1311     1281      -30     
  Lines        105413   103982    -1431     
  Branches       3297     3304       +7     
============================================
- Hits          44812    43476    -1336     
+ Misses        58655    58553     -102     
- Partials       1946     1953       +7     
Flag Coverage Δ
core 75.05% <ø> (ø)
editoast 73.65% <ø> (-0.05%) :arrow_down:
front 18.79% <17.59%> (+<0.01%) :arrow_up:
gateway 2.18% <ø> (-0.02%) :arrow_down:
osrdyne 3.28% <ø> (ø)
railjson_generator ?
tests 86.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 29 '24 15:10 codecov-commenter

Sorry for the duplicate comments. It seems @clarani and I ended up reviewing in parallel without noticing.

emersion avatar Nov 06 '24 14:11 emersion