osrd icon indicating copy to clipboard operation
osrd copied to clipboard

core: stdcm: fix time data on engineering allowances

Open eckter opened this issue 1 year ago • 1 comments

We wouldn't add engineering allowances to the travelled times, which messed with both cost functions and tests for maximum running time.

I've added an assert to check that time datas are consistent.

eckter avatar Oct 29 '24 14:10 eckter

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.61%. Comparing base (508ac32) to head (9a938c7). Report is 4 commits behind head on dev.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #9510      +/-   ##
============================================
- Coverage     39.62%   39.61%   -0.02%     
  Complexity     2270     2270              
============================================
  Files          1300     1300              
  Lines         99167    99169       +2     
  Branches       3283     3283              
============================================
- Hits          39297    39284      -13     
- Misses        57937    57952      +15     
  Partials       1933     1933              
Flag Coverage Δ
core 75.06% <100.00%> (+<0.01%) :arrow_up:
editoast 73.26% <ø> (-0.06%) :arrow_down:
front 10.23% <ø> (ø)
gateway 2.19% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 29 '24 14:10 codecov-commenter