osrd icon indicating copy to clipboard operation
osrd copied to clipboard

front: output table

Open anisometropie opened this issue 1 year ago • 2 comments

closes #7757

anisometropie avatar Jun 27 '24 07:06 anisometropie

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 19.74742% with 699 lines in your changes missing coverage. Please review.

Project coverage is 28.50%. Comparing base (e741331) to head (81b5d46).

Files Patch % Lines
...rc/modules/timesStops/hooks/useTimeStopsColumns.ts 0.00% 131 Missing and 1 partial :warning:
...src/modules/timesStops/hooks/useOutputTableData.ts 0.00% 108 Missing and 1 partial :warning:
front/src/modules/timesStops/TimesStopsInput.tsx 0.00% 88 Missing and 1 partial :warning:
front/src/modules/timesStops/TimesStopsOutput.tsx 0.00% 75 Missing and 1 partial :warning:
front/src/modules/timesStops/helpers/utils.ts 37.25% 54 Missing and 10 partials :warning:
front/src/modules/timesStops/TimesStops.tsx 0.00% 49 Missing :warning:
...les/trainschedule/useFormattedOperationalPoints.ts 0.00% 48 Missing and 1 partial :warning:
...perationalStudies/views/v2/SimulationResultsV2.tsx 0.00% 48 Missing :warning:
...c/modules/timesStops/helpers/formatScheduleData.ts 0.00% 22 Missing and 1 partial :warning:
...t/src/modules/timesStops/helpers/computeMargins.ts 82.66% 3 Missing and 10 partials :warning:
... and 10 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7855      +/-   ##
============================================
+ Coverage     28.45%   28.50%   +0.04%     
  Complexity     2123     2123              
============================================
  Files          1301     1309       +8     
  Lines        157770   158353     +583     
  Branches       3213     3243      +30     
============================================
+ Hits          44897    45135     +238     
- Misses       110935   111251     +316     
- Partials       1938     1967      +29     
Flag Coverage Δ
core 75.43% <ø> (ø)
editoast 70.38% <ø> (-0.03%) :arrow_down:
front 10.38% <19.74%> (+0.16%) :arrow_up:
gateway 2.03% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 73.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 27 '24 07:06 codecov-commenter

needs a margin between the table and the slopes compoent

image

fixed

anisometropie avatar Jun 27 '24 10:06 anisometropie

in SimulationResultsV2.tsx, still this block that seems useless

      {/* SIMULATION: TIMELINE — TEMPORARILY DISABLED
      {simulation.trains.length && (
      {simulation.trains.length && (
        <TimeLine
        <TimeLine
          timeScaleDomain={timeScaleDomain}
          timeScaleDomain={timeScaleDomain}
          selectedTrainId={selectedTrain?.id || simulation.trains[0].id}
          selectedTrainId={selectedTrain?.id || simulation.trains[0].id}
          trains={simulation.trains as SimulationReport[]}
          trains={simulation.trains as SimulationReport[]}
          onTimeScaleDomainChange={setTimeScaleDomain}
          onTimeScaleDomainChange={setTimeScaleDomain}
        />
        />
      )}
      */}

Yohh avatar Jul 09 '24 13:07 Yohh

nice, I spotted many times where you forget the type prefix, I just commented one but you have the same issue in TimeStopsColumns.tsx and TimesStops.tsx

I reviewed all the imports, I think the other spots were also for this enum, I think the rest of imports are ok

anisometropie avatar Jul 10 '24 10:07 anisometropie

Column titles in English doesn't fit:

image

flomonster avatar Jul 25 '24 09:07 flomonster