osrd
osrd copied to clipboard
front: output table
closes #7757
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 19.74742% with 699 lines in your changes missing coverage. Please review.
Project coverage is 28.50%. Comparing base (
e741331) to head (81b5d46).
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## dev #7855 +/- ##
============================================
+ Coverage 28.45% 28.50% +0.04%
Complexity 2123 2123
============================================
Files 1301 1309 +8
Lines 157770 158353 +583
Branches 3213 3243 +30
============================================
+ Hits 44897 45135 +238
- Misses 110935 111251 +316
- Partials 1938 1967 +29
| Flag | Coverage Δ | |
|---|---|---|
| core | 75.43% <ø> (ø) |
|
| editoast | 70.38% <ø> (-0.03%) |
:arrow_down: |
| front | 10.38% <19.74%> (+0.16%) |
:arrow_up: |
| gateway | 2.03% <ø> (ø) |
|
| railjson_generator | 87.49% <ø> (ø) |
|
| tests | 73.18% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
needs a margin between the table and the slopes compoent
fixed
in SimulationResultsV2.tsx, still this block that seems useless
{/* SIMULATION: TIMELINE — TEMPORARILY DISABLED
{simulation.trains.length && (
{simulation.trains.length && (
<TimeLine
<TimeLine
timeScaleDomain={timeScaleDomain}
timeScaleDomain={timeScaleDomain}
selectedTrainId={selectedTrain?.id || simulation.trains[0].id}
selectedTrainId={selectedTrain?.id || simulation.trains[0].id}
trains={simulation.trains as SimulationReport[]}
trains={simulation.trains as SimulationReport[]}
onTimeScaleDomainChange={setTimeScaleDomain}
onTimeScaleDomainChange={setTimeScaleDomain}
/>
/>
)}
*/}
nice, I spotted many times where you forget the type prefix, I just commented one but you have the same issue in
TimeStopsColumns.tsxandTimesStops.tsx
I reviewed all the imports, I think the other spots were also for this enum, I think the rest of imports are ok
Column titles in English doesn't fit:
