PySyft icon indicating copy to clipboard operation
PySyft copied to clipboard

Single container launching added to tox and workflows

Open snwagh opened this issue 1 year ago • 2 comments
trafficstars

Description

This adds a new tox environment to run a backend container. The workflows will automatically run this before running all the tests.

Note: Created the PR even though it's not fully bug free since it is blocking Tauquir.

snwagh avatar May 01 '24 18:05 snwagh

Notes about the failing tests

  • 10-container-images.ipynb. So when I run the following commands:
cd packages/
docker build -f grid/backend/backend.dockerfile . -t backend:0.1
docker run -d -e SINGLE_CONTAINER_MODE=true -p 8080:80 --name mybackend backend:0.1
tox -e stack.test.notebook

the test fails because it tries to pull an image from openmined/grid-backend:tag where tag gets set to local-dev because when we run the tox command, we modified this setenv ORCHESTRA_DEPLOYMENT_TYPE = {env:ORCHESTRA_DEPLOYMENT_TYPE:k8s}. But when I visit OpenMined's dockerhub page after logging into my account, I do not see any image tagged local-dev (I don't think it's a perms issue with my docker account). That is what is making the test fail since it's unable to load that base image in this command:

custom_dockerfile_str = f"""
FROM openmined/grid-backend:{syft_base_worker_tag}

RUN pip install pydicom

""".strip()

Not sure what the right fix to this is.

  • 12-custom-api-endpoint.ipynb This test I have not been able to figure out a way to debug the error stack. Will continue working on this.

snwagh avatar May 01 '24 18:05 snwagh

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB