open-interpreter icon indicating copy to clipboard operation
open-interpreter copied to clipboard

Move get_storage_path to further decouple Core from Terminal Interface

Open MikeBirdTech opened this issue 1 year ago • 1 comments

Describe the changes you have made:

One more step towards decoupling Core from Terminal Interface by moving get_storage_path util into Core.

OpenInterpreter objects are initialized with a conversation_history_path field which is assigned the return of get_storage_path('conversations') so it makes sense to have this util within Core instead of Terminal Interface.

interpreter/terminal_interface/conversation_navigator.py can use interpreter.conversation_history_path instead of calling get_storage_path('conversations') since the interpreter instance will have already determined this value.

interpreter/terminal_interface/utils/get_conversations.py wasn't being used - deleted it.

However, interpreter/terminal_interface/utils/profiles.py is now coupled to core because of this change. I think a bigger conversation around profiles is needed. Is it enough that Terminal Interface has the oi_dir util? If needed, can other directories be generated here? If Profiles are configuring OpenInterpreter fields, should they be moved to Core too?

interpreter/terminal_interface/utils/ARCHIVE_get_config.py is now coupled to core but with this util being archived, I didn't think it was worth a deeper investigation.

Reference any relevant issues (e.g. "Fixes #000"):

Pre-Submission Checklist (optional but appreciated):

  • [x] I have included relevant documentation updates (stored in /docs)
  • [x] I have read docs/CONTRIBUTING.md
  • [x] I have read docs/ROADMAP.md

OS Tests (optional but appreciated):

  • [ ] Tested on Windows
  • [x] Tested on MacOS
  • [ ] Tested on Linux

MikeBirdTech avatar Jan 30 '24 23:01 MikeBirdTech

Tested on windows, updated it to upstream/main

Notnaton avatar Feb 03 '24 14:02 Notnaton