open-interpreter icon indicating copy to clipboard operation
open-interpreter copied to clipboard

Added batch, bat aliases for shell language

Open CyanideByte opened this issue 1 year ago • 1 comments
trafficstars

Describe the changes you have made:

  • Added aliases 'batch' and 'bat' to the shell language to match the linux/mac aliases.

Reference any relevant issues (e.g. "Fixes #000"):

  • Handles the case when local models try to run 'batch' instead of 'shell' on Windows.
  • Partially related to: https://github.com/OpenInterpreter/open-interpreter/issues/1231#issuecomment-2073577430

Pre-Submission Checklist (optional but appreciated):

  • [ ] I have included relevant documentation updates (stored in /docs)
  • [x] I have read docs/CONTRIBUTING.md
  • [x] I have read docs/ROADMAP.md

OS Tests (optional but appreciated):

  • [x] Tested on Windows
  • [ ] Tested on MacOS
  • [ ] Tested on Linux

CyanideByte avatar Apr 27 '24 23:04 CyanideByte

Should be under powershell.py ?

Batch and bat is for windows

Batch scripts have always been running under shell through jupyter even without the aliases. This is just to catch a few cases where models specifically mention batch or bat. I think powershell is differentiated because its running in a separate process. Jupyter might be able to run powershell as well I'm not sure, but also powershell can't run batch scripts directly.

CyanideByte avatar Apr 30 '24 04:04 CyanideByte

Great work as always @CyanideByte and many thanks @Notnaton for reviewing! Merged.

KillianLucas avatar May 04 '24 21:05 KillianLucas