fastp icon indicating copy to clipboard operation
fastp copied to clipboard

Remove the use of getBytes (seekg)?

Open xzhub opened this issue 4 years ago • 1 comments

In order to replace the slow inbuilt gzip lib, we'd like to use pigz. However, the following command failed:

fastp -i <(gzip -dc input_1.fq.gz) -I <(gzip -dc input_2.fq.gz)  -o ...... 

after some investigation, I guess the issue is coming from getBytes(), because fseek is not supported by stream. code: https://github.com/OpenGene/fastp/blob/424900e376a02033a32b623bc5c836897f6b7e5a/src/fastqreader.cpp#L68

Is it possible to remove the use of fseek so we can pipe the stream to fastp? Or any other suggestions on how to use pigz with fastp? (without creating temporary files)

xzhub avatar Apr 27 '21 04:04 xzhub

for speeding up compress and decompress, u can try zlib-ng if u know what I am saying

KimBioInfoStudio avatar Aug 17 '21 15:08 KimBioInfoStudio

Please explain as I don't know what you are saying and am trying to use pigz with fastp. Thank you.

bmillerlab avatar Oct 08 '22 20:10 bmillerlab